From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 803E21FF0C0 for ; Wed, 18 Nov 2026 13:24:29 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4A37A21778; Wed, 18 Nov 2026 13:24:08 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 1/3] fix #8331: snapshot: fix regression with endless loop after error Date: Wed, 18 Nov 2026 13:21:47 +0100 Message-ID: <20261118122359.123647-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118122359.123647-1-f.ebner@proxmox.com> References: <20261118122359.123647-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795004642448 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.251 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VBMGCT5GSDBYCSH3HJBHXVRCNF7KU7IM X-Message-ID-Hash: VBMGCT5GSDBYCSH3HJBHXVRCNF7KU7IM X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The loop in the 'after-unfreeze' hook phase relies on the 'bytes' value from the result of 'query-savevm' disappearing when the 'savevm-end' command is done. This does not happen in case of an error status currently. Use a timeout of 35 seconds instead to ensure that the loop stays bounded. A further improvement requires QEMU to report more information with 'query-savevm'. Fixes: 568b295c ("fix #7697: snapshot hook name mismatch") Signed-off-by: Fiona Ebner --- src/PVE/QemuConfig.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm index d89a62e6..f35a49eb 100644 --- a/src/PVE/QemuConfig.pm +++ b/src/PVE/QemuConfig.pm @@ -390,11 +390,16 @@ sub __snapshot_create_vol_snapshots_hook { }; warn $@ if $@; } elsif ($hook eq "after-unfreeze") { - # savevm-end is async, we need to wait + # savevm-end is async and waits for up to 30 seconds for closing the target. + my $timeout = 35; + my $start_time = time(); for (;;) { my $stat = mon_cmd($vmid, "query-savevm"); if (!$stat->{bytes}) { last; + } elsif ((time() - $start_time) >= $timeout) { + warn "timeout waiting for 'savevm-end' to complete\n"; + last; } else { print "waiting for QEMU to finish the 'savevm-end' command...\n"; sleep(1); -- 2.47.3