From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C5FAA1FF0C0 for ; Wed, 18 Nov 2026 13:24:15 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 804BB21714; Wed, 18 Nov 2026 13:24:07 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES qemu-server/qemu 0/3] fix #8331: snapshot: fix regression with endless loop after error Date: Wed, 18 Nov 2026 13:21:46 +0100 Message-ID: <20261118122359.123647-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795004642390 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.252 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZGRT6C73RIQZVJ3N4YKTWE33FYRROTTS X-Message-ID-Hash: ZGRT6C73RIQZVJ3N4YKTWE33FYRROTTS X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The loop in the 'after-unfreeze' hook phase relies on the 'bytes' value from the result of 'query-savevm' disappearing when the 'savevm-end' command is done. This does not happen in case of an error status currently. Use a timeout of 35 seconds instead to ensure that the loop stays bounded. This phase was enabled by commit 568b295c ("fix #7697: snapshot hook name mismatch") so this is an unintended regression. Further improve the situation by having 'query-savevm' report if 'savevm-end' is still active and qemu-server checking for that. qemu-server: Fiona Ebner (2): fix #8331: snapshot: fix regression with endless loop after error snapshot: directly check for savevm-end status src/PVE/QemuConfig.pm | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) qemu: Fiona Ebner (1): async snapshot: keep track of savevm-end status migration/savevm-async.c | 13 +++++++++++++ qapi/migration.json | 6 +++++- 2 files changed, 18 insertions(+), 1 deletion(-) Summary over all repositories: 3 files changed, 30 insertions(+), 3 deletions(-) -- Generated by git-murpp 0.5.0