From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-access-control v4 1/6] rpcenv: add SDN.Allocate to modify permission check
Date: Wed, 18 Nov 2026 12:57:52 +0100 [thread overview]
Message-ID: <20261118115757.94919-2-d.riley@proxmox.com> (raw)
In-Reply-To: <20261118115757.94919-1-d.riley@proxmox.com>
Map the entire SDN namespace ('/sdn/*') to the 'SDN.Allocate'
privilege when verifying resource modification rights.
Previously, the access control helper lacked a dedicated mapping for
SDN resources. This caused checks to fall back to strictly requiring
global admin rights ('Permissions.Modify'), which prevented downstream
API endpoints from properly verifying allocation rights for standard
users trying to manage SDN resources.
Fixes: edc2154 ("fix #7294: acl: pool: add SDN VNets as pool members")
Signed-off-by: David Riley <d.riley@proxmox.com>
---
src/PVE/RPCEnvironment.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/PVE/RPCEnvironment.pm b/src/PVE/RPCEnvironment.pm
index 0104b1e..09854d5 100644
--- a/src/PVE/RPCEnvironment.pm
+++ b/src/PVE/RPCEnvironment.pm
@@ -524,6 +524,8 @@ sub check_perm_modify {
push @$testperms, 'Datastore.Allocate';
} elsif ($path =~ m|^/vms/.+$|) {
push @$testperms, 'VM.Allocate';
+ } elsif ($path =~ m|^/sdn/.+$|) {
+ push @$testperms, 'SDN.Allocate';
} elsif ($path =~ m|^/pool/.+$|) {
push @$testperms, 'Pool.Allocate';
}
--
2.47.3
next prev parent reply other threads:[~2026-11-18 11:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 11:57 [PATCH access-control/manager/network v4 0/6] fix #7294: pool: add SDN VNets as pool members David Riley
2026-11-18 11:57 ` David Riley [this message]
2026-11-18 11:57 ` [PATCH pve-network v4 2/6] sdn: register api formats for zones and vnets David Riley
2026-11-18 11:57 ` [PATCH pve-network v4 3/6] fix #7294: sdn: vnet: update pool members on vnet migration and deletion David Riley
2026-11-18 11:57 ` [PATCH pve-manager v4 4/6] ui: replace var with let to match style guide for variable declaration David Riley
2026-11-18 11:57 ` [PATCH pve-manager v4 5/6] fix #7294: api: pool: add SDN VNets as pool members David Riley
2026-11-18 11:57 ` [PATCH pve-manager v4 6/6] fix #7294: ui: " David Riley
2026-11-19 12:49 ` superseded: [PATCH access-control/manager/network v4 0/6] fix #7294: " David Riley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261118115757.94919-2-d.riley@proxmox.com \
--to=d.riley@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.