From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A25551FF0C0 for ; Wed, 18 Nov 2026 11:32:06 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BBB6521809; Wed, 18 Nov 2026 11:31:34 +0100 (CET) From: Thomas Ellmenreich To: pve-devel@lists.proxmox.com Subject: [PATCH common v2 08/11] pem parsing: default splitting to any label Date: Wed, 18 Nov 2026 11:31:22 +0100 Message-ID: <20261118103127.165100-9-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118103127.165100-1-t.ellmenreich@proxmox.com> References: <20261118103127.165100-1-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794997889745 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.336 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QPTPZXL3LGLIFS3Z5YX722AB3MCO2XMX X-Message-ID-Hash: QPTPZXL3LGLIFS3Z5YX722AB3MCO2XMX X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Default 'split_pem' to use any label instead of CERTIFICATE as returning all chain entries is a more sensible default. Signed-off-by: Thomas Ellmenreich --- src/PVE/Certificate.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm index c1e0368..620ba6b 100644 --- a/src/PVE/Certificate.pm +++ b/src/PVE/Certificate.pm @@ -166,7 +166,7 @@ sub split_pem { my ($content, %opts) = @_; $content = trim_trailing_space($content); - my $footer = $footer_re->($opts{label} // 'CERTIFICATE'); + my $footer = $footer_re->($opts{label} // $ANY_LABEL); return $content =~ /(.*?$footer)/sg; } -- 2.47.3