From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D47611FF0C0 for ; Wed, 18 Nov 2026 11:31:34 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8518121778; Wed, 18 Nov 2026 11:31:32 +0100 (CET) From: Thomas Ellmenreich To: pve-devel@lists.proxmox.com Subject: [PATCH common v2 03/11] pem parser: refactor check_pem to use list instead of string Date: Wed, 18 Nov 2026 11:31:17 +0100 Message-ID: <20261118103127.165100-4-t.ellmenreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118103127.165100-1-t.ellmenreich@proxmox.com> References: <20261118103127.165100-1-t.ellmenreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794997889258 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.343 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YLAGTJCEW4QBYMVZAK7SIF2VCTVBXTSH X-Message-ID-Hash: YLAGTJCEW4QBYMVZAK7SIF2VCTVBXTSH X-MailFrom: t.ellmenreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Thomas Ellmenreich X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: In preparation for future changes, refactor the check_pem subroutine to add each new found entry onto a list, which is then concatenated into a single string. Signed-off-by: Thomas Ellmenreich --- src/PVE/Certificate.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/PVE/Certificate.pm b/src/PVE/Certificate.pm index a046dc8..8e6305a 100644 --- a/src/PVE/Certificate.pm +++ b/src/PVE/Certificate.pm @@ -165,17 +165,18 @@ sub check_pem { die "PEM chain could not be split into separate entries\n"; } - my $result_pem = ""; + my @result_entries = (); for my $entry (@split) { my $stripped = strip_leading_text($entry); if ($stripped !~ /^$re$/) { - $result_pem = ""; + @result_entries = (); last; } - $result_pem .= $stripped; + push @result_entries, $stripped; } + my $result_pem = join "", @result_entries; return $result_pem if $result_pem; -- 2.47.3