From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id AA86F1FF0C0 for ; Wed, 18 Nov 2026 10:07:57 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B8114215FD; Wed, 18 Nov 2026 10:07:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JvwRKqFVCeM5rD8nRiDo9oiaXW30dC8YR1rRAx6OuHmRGSE+uPTSdNBfaCRKHqXCXZbDdfxnzu9QC65g5rsKTa9J0ZJ8CBz4WrdzTH3jlefI/tm27Vyc685sbQDZSgiNLV/eMjkhZKapHSTK8y+4WVJHhIXt6ZjczUtc0X4n8WhtdxIe4aLjC7mo5zS5s/pE8sOvYJ0WZz9g4cPkIK2jvkHmxnfj7gzZRUnCp1xSgLxJX9k+kmIuY/3Of7g0WfwdylvKhMxYt3k9lrAojyp4hYYmEMAxeGvfHk2RWeAv8YUa/uit46RWr6bC3CMOOb4wcC2TZCFF393no8f/xJHpSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zOyWUzX+xs5KD5VUGxJmWuRD8D4sTL8f3rSz+SVmKmY=; b=iJZjnePWjvwHSI3U76wZvQUcPJd4UlmwCzeaguuMPPW/6mA9MqkreVDS5QYLhOpwE/tc1cKnTKjUfI7fPom2F3oUS4vpfVN1/Ix9LXtdurevS5mTuW82h/WKKJZCiLZSeKDLuRXEtuVfaxLsxZn6wYK9I7L73acoPWm+p/tMevzIppzUijTM6M0JvKAYA51hpuhZJo/cVBETxtF5QmP06sDuyxej6nRLXNADTaCpM+B8j7KYySPN5Z5GWlYZl3GagfL0DxrMJhDVmBjFkauZUHZNh5IbcnWDBsitg0mHaDZvElNTiatASfQdN6PZHOMWxaT1XQSyEyB6mZJMUSAiiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cyber.gent; dmarc=pass action=none header.from=cyber.gent; dkim=pass header.d=cyber.gent; arc=none Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cyber.gent; From: Yvan Janssens To: pve-devel@lists.proxmox.com Subject: [PATCH pve-cluster] pmxcfs: check_memdb: accept the big-endian index checksum Date: Wed, 18 Nov 2026 10:07:35 +0100 Message-ID: <20261118090735.71816-1-yvanj@cyber.gent> X-Mailer: git-send-email 2.54.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AS8PR05CA0003.eurprd05.prod.outlook.com (2603:10a6:20b:311::8) To DBAP193MB0876.EURP193.PROD.OUTLOOK.COM (2603:10a6:10:1cc::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBAP193MB0876:EE_|PR3P193MB1070:EE_ X-MS-Office365-Filtering-Correlation-Id: 8f100870-080a-4fab-48c6-08df455364bf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|23010399003|10070799003|366016|18002099003|261009223027099003|56012099006|261102123227099003|261028144727099003|10067099003|261026140227099003|261021121427099003|261022105027099003|261022075727099003|261021123027099003; X-Microsoft-Antispam-Message-Info: glUG7h8+mZu5gC7JjlYCySZ2HiYC2KiaRHTi5TJudIm49ZD7BfeCJTKr9bYswtKjsHJaJ64N0WCcfxTzxMJi2sPoYhd+jA1GCNVWR/Tn42qeOZHW1O44v5ZzlnRXVAztaQGeJUCRnoKG2o6n4/O92SwKH/6HbbouS5ugxeh+X4na6KAeSPwA/T68/tSILb/vEFpKSY+A9aar2VzOrmGhlfKcyLyPT6wF322ih/kMx1omPUK2AobZCm4o6OfE59WpsY9lVnO3DygeioKAFu/TPwomOLujD1u4crDA34RCI9TbNkeug9iYyP2mSlTa+HOA6w2pQ1kSyTbUjFvirG7jTUsC9WjVGVCgLDNCGT1TlePNizGZ+O0WsqbpCR540f/RlrWPP1FT1cw27wHzzdp6cIqCMMCBsv0ckBwBAVO0UQ99zMAQ+sPhk4URwPd3PouR3dpg2AGCMFt8ny/7a09PgcOfqQt+vkuEnqFsuYq2AYX7zWhkIkRBZhJ71ZzBG5tNJ9AVOn/49NtdsK40j7MBCUBTWvKPvxVkB3Sc5MCdJSdsUmufGCW2SQLOslkbuFyOX+PnEUrCAijbdeEEkEwVMnAW7VF7jIXvCbGxPIosygTHadwfsGY/lQZZQ33m/QnFOx7by6sWfX1VEwpvYCxh0RCWf7AXDNbavE5aZjfq3WM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBAP193MB0876.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(23010399003)(10070799003)(366016)(18002099003)(261009223027099003)(56012099006)(261102123227099003)(261028144727099003)(10067099003)(261026140227099003)(261021121427099003)(261022105027099003)(261022075727099003)(261021123027099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T1G3mF7G1wgbNoOtoEk9tDQtF/HTgk44H9SGiuMYi7fROFIxBCCpNg4kegOG?= =?us-ascii?Q?NPr07MHbmo39zfjw1mlWeK1wpP2hX7K6ujfPsMh4Yv/U8lMi2MO7eFJYW2ix?= =?us-ascii?Q?xiUl/gVr7VMnar9mnN/chIYPOn//h6bztGxhr99iUxQd7qHb2kjGng/N0qGJ?= =?us-ascii?Q?ttim7upr+6zA1jTeITSw6dzAWDD+/XeQUvPBILudMSHgbJ0VQZ3gGm7eUH/o?= =?us-ascii?Q?gV5pSJEGRNu4owsSEedc9H8xUQJA4Yh8khcENh8tck5ZeDEUEdJLnVRTMvn5?= =?us-ascii?Q?Cu+uPGEw5Un1eEAUDKzXH4h0Pv8tJVoCjsTgE7BEEDXuTWZoZMssld7Cmtyx?= =?us-ascii?Q?DTHo911nm1PMCh3aQlMeY6hxTjQat14BrWM4lyeDX3udZ902eFjmQJD2Jcsr?= =?us-ascii?Q?suOYmIF7oUvZ3OFCpuIEVxzNRTgU7tem0TPrBXvhToc3EjzIj0pQbdvX990q?= =?us-ascii?Q?JOYOSVIOUV6KcEHxyfTHu4GTbMRgr8ZFu5tXHuZaEfp/M1jvN+m9Z2YGpRZe?= =?us-ascii?Q?WDs1Q7EPKdadyrhhZSNQVE61+08sY8CSwa9/YmM+fI0Wpk1GX1Quq2gFqMAc?= =?us-ascii?Q?FdTx7HjX1fy1+8Yl6A0sMUah1dY6rWq2rQt0qkilUnsZ8unKcIP4piFPwuIV?= =?us-ascii?Q?xel/sKoQLB6MJaClLmpepRMGveZF9sVaVfCLYk6SRaJEawpRvILbi5R1Svp1?= =?us-ascii?Q?WiiOs23u/G+L/sEMdnIHoR4I+xrcdTG2rSBmw7UeJPnXQdai1e2qFk8HUw73?= =?us-ascii?Q?Qk6VEBaiCUrEHnrAaySGhPAVvTPFML+Iuzrkra9+ztCfp9WMZF5vbEqBluJU?= =?us-ascii?Q?OFCrjndpVI9q9Axp0sDrSDsQi7czS1WUAbGnrp7TudhLCB6+amEmTGoCL2At?= =?us-ascii?Q?3xEamUbE7RyzwRiXTYRC03MsK3/Cch/EH00Oe+ZSiamcb8KbpyVzNfqDqvQQ?= =?us-ascii?Q?Hi20XF1z/kgdHjWkgpHYH89oNlk0yDodbwZTp9Xn1VBqTRsSEmpAM7KapfIW?= =?us-ascii?Q?H/kkHniwq7UWxVYdrvR59gmiBiHgITKGFvyfIogR8EWwRNc4bE4Kuq5zfAER?= =?us-ascii?Q?Xd9RGqM/K4f7URjhgNNFrTtM3LlmQiwsbvO24MJzuoTQNHPLXlndU2+OTt5L?= =?us-ascii?Q?6hjhc1e004rla/r+M0zFoLChxG+pMbtZ7S8E1X6muZB6j+DivoqDwtWThZ7k?= =?us-ascii?Q?q970XNMxvleV1TZq2zj+13HdQ/WVy6CwOPdhbwx7UmGl42Bv6K4D14dXKiWd?= =?us-ascii?Q?D2HULlx8NWTbuzuwB2bGJ8V7eAzvGkqiZHGZKlRYyCTBn4SwhBaYMlSeZDnN?= =?us-ascii?Q?t2hb+4s3Y+Uy2cw4pYUh6OF03dHdaIepv2T954aUJD593GHTNQKw26NndscS?= =?us-ascii?Q?v5aXXkEtKLJ0kj8Ap0ZVdzAGa/ltnrFEj+9YvlCL2Qcpsw//1ORQ87j4i4Oh?= =?us-ascii?Q?xMx+8yWDfLrhuVqkUNrF8rL1Z+LzFksBxA/5S8XvpUfBo1hT/EFhoj4eRLgo?= =?us-ascii?Q?xWe/rbuKVA9V81d9XohkrSap83jqnjkzNzdCeOklAUbykTmORjhGtkO3NbnQ?= =?us-ascii?Q?F7FRT201aLVtyx6IMqeOrZjfqlDYHt6cX7GwCx08P/317zEGwv1yjqBxtgmr?= =?us-ascii?Q?DRJt661D3/NTo6NgdFRKAZo5Tub+lMYL9i4LUBTrsZYzmerOXWSmWDir1tol?= =?us-ascii?Q?ZY/C0RNE1I/gqpHMnAADNIv9AehovCcdamyEkJYGhjYJWu1f9DiFvx2NjQw9?= =?us-ascii?Q?T+U4dWdJNA=3D=3D?= X-OriginatorOrg: cyber.gent X-MS-Exchange-CrossTenant-Network-Message-Id: 8f100870-080a-4fab-48c6-08df455364bf X-MS-Exchange-CrossTenant-AuthSource: DBAP193MB0876.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Nov 2026 09:07:38.5856 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d5a0a0d6-18b4-44e3-8e5e-e5dbe37f9ee2 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P/ROhIOoI+hoSb+l/ElVc426uwFS6x/TSszpW+nZ/Ay545XYsj275F1O3urRQEadUWgGvGJu76y0XjI9w43R3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3P193MB1070 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.126 Adjusted score from AWL reputation of From: address DMARC_PASS -0.1 DMARC pass policy GB_MSAUTHSOURCE_EUROPE 0.01 Mail authenticated via Microsoft Europe (EURP) datacenter KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 4TX43PIDMW52UOGA5RGPWK65E7BXQCZU X-Message-ID-Hash: 4TX43PIDMW52UOGA5RGPWK65E7BXQCZU X-MailFrom: yvanj@cyber.gent X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The memdb index and its per-entry digests are built from host-endian integers, so the checksum hard-coded in test_indextest1 only matches on little-endian hosts, and the test fails on every big-endian one (for example s390x and big-endian ppc64). Add the big-endian checksum. On s390x, converting all integers to little-endian before hashing reproduces the existing checksum, so both values describe the same index. As the index has only fixed-width fields, the big-endian value holds for any big-endian host. Signed-off-by: Yvan Janssens --- src/pmxcfs/check_memdb.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/pmxcfs/check_memdb.c b/src/pmxcfs/check_memdb.c index 74728df..616ae61 100644 --- a/src/pmxcfs/check_memdb.c +++ b/src/pmxcfs/check_memdb.c @@ -270,10 +270,13 @@ START_TEST(test_indextest1) { ck_assert(sha256 != NULL); g_checksum_update(sha256, (unsigned char *)idx, idx->bytes); const char *csum = g_checksum_get_string(sha256); - ck_assert_msg( - strcmp(csum, "913fd95015af9d93f10dd51ba2a7bb11351bcfe040be21e95fcba834adc3ec10") == 0, - "wrong idx checksum %s", csum - ); + /* the index and its per-entry digests are built from host-endian integers */ +#if G_BYTE_ORDER == G_BIG_ENDIAN + const char *expected = "efdfcdde67acb6b48e4b415a172d5a1897c725b03a9b2c12d20efe0ab8adad44"; +#else + const char *expected = "913fd95015af9d93f10dd51ba2a7bb11351bcfe040be21e95fcba834adc3ec10"; +#endif + ck_assert_msg(strcmp(csum, expected) == 0, "wrong idx checksum %s", csum); g_free(idx); g_free(testdata); } -- 2.54.0 (Apple Git-157)