From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 7D4951FF0AA for ; Tue, 17 Nov 2026 23:41:14 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B2F5B2169A; Tue, 17 Nov 2026 23:40:37 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH cluster/guest-common/qemu-server/container/manager/docs v2 00/36] fix #7846: guest identity (uid) and cluster ID Date: Tue, 17 Nov 2026 23:34:10 +0100 Message-ID: <20261117223945.862914-1-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794955190304 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.200 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LNAAUAPF6Y7IEYWQDUGSXEBIFQ4JZHSA X-Message-ID-Hash: LNAAUAPF6Y7IEYWQDUGSXEBIFQ4JZHSA X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A VMID can be reused for another guest, and a guest can get another VMID or move to another cluster through a restore or a remote migration. So backup software and other tools cannot tell whether they still look at the same guest, see [0]. This series gives every VM and container a guest identity in the read-only 'meta' property: a random uid (100 bits as 20 base32 characters) and the time the guest was registered in the cluster. Create and clone get a new uid. Config changes, migration, rollback, backup and restore keep it, also under another VMID or in another cluster, as long as no other guest there has it. Each cluster or standalone node also gets a cluster ID in the same format, generated and protected by pmxcfs. The docs patches describe the details. The uid is a plain random nonce: 100 bits make a duplicate practically impossible and fit into a 128-bit value with room to spare, and 20 base32 characters stay short and need no quoting. The registration time is separate from the creation time, which clones, restores and remote migrations copy along. It changes when a guest gets registered again, so tools can tell such a guest from the one they knew. Three behavior changes come with it: * Restoring over an existing guest whose uid differs from the one of the backup is refused unless 'allow-identity-mismatch' is set. 'force' alone does not override this. * A migration to another cluster is refused if another guest there already has the uid, unless 'allow-new-uid' is set. The check runs before anything is transferred. PDM does not know the option yet. * Older versions drop the whole 'meta' property of a guest that has an identity. So migration and clone to such nodes is refused, and remote migration bumps the tunnel version. This also hits moves by the HA stack, which stops a container or a relocated VM before the migration gets refused. A target check in the LRM that avoids this will follow separately. The patches are in dependency order: guest-common needs pve-cluster, qemu-server and container need guest-common, and manager needs all of them. manager also has to depend on the qemu-server and container versions with this series, as the migration guard takes the pve-manager version of a node as proof that the node keeps the identity. MIN_PVE_MANAGER_VERSION in guest-common is a stand-in for that version. Besides fully build-testing every commit, also tested this on simple pmxcfs with corosync in network namespaces, and end to end on a nested three-node cluster that was upgraded node by node, with external remote migrations to a standalone node. changes v1 -> v2, thanks to Dominik for the review: * rebase onto current master (tracking of used guest IDs, dfsm rework) * remote migration takes the uid over at its start and refuses a uid that is in use in the target cluster, unless 'allow-new-uid' is set * qemu-server and container share the restore checks and messages through pve-guest-common, with fewer special cases * IDs take each character from one random byte, without an encoder * the clone dialog does not offer nodes that would drop the identity, and a bulk migration checks its target once (new patch 32) * independent fixes moved out of the series and got applied on their own: the IPC client error, the order of removing firewall and guest config, and the cleanup of a remote migration target after failures * comments, commit messages and docs give the reasons for the format, for rtime next to ctime and for the separate lock Details are in the notes below the "---" of each patch. v1: https://lore.proxmox.com/pve-devel/20261116004703.2908294-1-t.lamprecht@proxmox.com/ [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=7846 cluster: Thomas Lamprecht (7): pmxcfs: reject changes to the cluster ID file from user space pmxcfs: generate a cluster ID on standalone nodes pmxcfs: dfsm: add a callback that runs once all members are in sync pmxcfs: quorum: pass the corosync membership to an optional listener pmxcfs: dcdb: generate the cluster ID once the cluster is in sync cluster: add helper to read the cluster ID pmxcfs: allow removing the cluster ID file in forced local mode src/PVE/Cluster.pm | 16 ++ src/pmxcfs/Makefile | 12 +- src/pmxcfs/cfs-plug-memdb.c | 46 ++++ src/pmxcfs/cfs-utils.c | 8 + src/pmxcfs/cfs-utils.h | 5 + src/pmxcfs/check_dcdb.c | 530 ++++++++++++++++++++++++++++++++++++ src/pmxcfs/check_memdb.c | 283 +++++++++++++++++++ src/pmxcfs/cluster-id.c | 142 ++++++++++ src/pmxcfs/cluster-id.h | 50 ++++ src/pmxcfs/dcdb.c | 144 ++++++++++ src/pmxcfs/dcdb.h | 5 + src/pmxcfs/dfsm.c | 59 ++++ src/pmxcfs/dfsm.h | 14 + src/pmxcfs/pmxcfs.c | 10 +- src/pmxcfs/quorum.c | 26 +- src/pmxcfs/quorum.h | 8 +- src/pmxcfs/status.c | 12 + src/pmxcfs/status.h | 3 + src/test/Makefile | 6 +- src/test/test_cluster_id.pl | 46 ++++ 20 files changed, 1413 insertions(+), 12 deletions(-) create mode 100644 src/pmxcfs/check_dcdb.c create mode 100644 src/pmxcfs/cluster-id.c create mode 100644 src/pmxcfs/cluster-id.h create mode 100644 src/test/test_cluster_id.pl guest-common: Thomas Lamprecht (4): guest identity: add helpers for the guest uid and registration time abstract config: assign a guest identity and keep it on config writes abstract config: let the VMID reservation return the previous state guest identity: allow taking over a uid that is unused in the cluster src/Makefile | 1 + src/PVE/AbstractConfig.pm | 196 ++++- src/PVE/GuestIdentity.pm | 475 +++++++++++ src/tests/Makefile | 10 +- src/tests/config-identity-tests.pl | 1173 ++++++++++++++++++++++++++++ src/tests/guest-identity-tests.pl | 530 +++++++++++++ 6 files changed, 2378 insertions(+), 7 deletions(-) create mode 100644 src/PVE/GuestIdentity.pm create mode 100755 src/tests/config-identity-tests.pl create mode 100755 src/tests/guest-identity-tests.pl qemu-server: Thomas Lamprecht (7): api: restore: release the VMID if a restore to an unused VMID fails api: migrate, clone: refuse targets that would drop the guest identity fix #7846: config: add a guest identity to the 'meta' property restore: take over the guest uid from the backup where possible api: remote migration: take over the guest uid from the source api: status: return the guest uid tests: remote migration: check a failed command and an early tunnel end src/PVE/API2/Qemu.pm | 120 ++- src/PVE/CLI/qm.pm | 7 + src/PVE/CLI/qmrestore.pm | 11 +- src/PVE/QemuConfig.pm | 7 + src/PVE/QemuMigrate.pm | 38 +- src/PVE/QemuServer.pm | 107 +- src/PVE/QemuServer/MetaInfo.pm | 2 + src/test/Makefile | 5 +- src/test/QemuServerTest/FakeCFS.pm | 188 ++++ .../q35-windows-pinning-identity-only.conf | 6 + ...q35-windows-pinning-identity-only.conf.cmd | 26 + .../meta-identity-invalid.conf | 6 + .../meta-identity-invalid.conf.strict.error | 2 + .../meta-identity-invalid.conf | 7 + .../parse-config-input/meta-identity.conf | 20 + src/test/restore-config-expected/150.conf | 9 + src/test/restore-config-input/150.conf | 10 + src/test/run_api_tests.pl | 190 ++++ src/test/run_guest_identity_tests.pl | 752 ++++++++++++++ src/test/run_parse_config_tests.pl | 2 +- src/test/run_qemu_restore_config_tests.pl | 915 +++++++++++++++++- .../create/qemu-server/401.conf | 31 + .../create/qemu-server/402.conf | 31 + .../rollback/qemu-server/401.conf | 36 + .../rollback/qemu-server/402.conf | 35 + .../create/qemu-server/401.conf | 13 + .../create/qemu-server/402.conf | 13 + .../rollback/qemu-server/401.conf | 35 + .../rollback/qemu-server/402.conf | 34 + src/test/snapshot-test.pm | 82 +- 30 files changed, 2674 insertions(+), 66 deletions(-) create mode 100644 src/test/QemuServerTest/FakeCFS.pm create mode 100644 src/test/cfg2cmd/q35-windows-pinning-identity-only.conf create mode 100644 src/test/cfg2cmd/q35-windows-pinning-identity-only.conf.cmd create mode 100644 src/test/parse-config-expected/meta-identity-invalid.conf create mode 100644 src/test/parse-config-expected/meta-identity-invalid.conf.strict.error create mode 100644 src/test/parse-config-input/meta-identity-invalid.conf create mode 100644 src/test/parse-config-input/meta-identity.conf create mode 100644 src/test/restore-config-expected/150.conf create mode 100644 src/test/restore-config-input/150.conf create mode 100755 src/test/run_guest_identity_tests.pl create mode 100644 src/test/snapshot-expected/create/qemu-server/401.conf create mode 100644 src/test/snapshot-expected/create/qemu-server/402.conf create mode 100644 src/test/snapshot-expected/rollback/qemu-server/401.conf create mode 100644 src/test/snapshot-expected/rollback/qemu-server/402.conf create mode 100644 src/test/snapshot-input/create/qemu-server/401.conf create mode 100644 src/test/snapshot-input/create/qemu-server/402.conf create mode 100644 src/test/snapshot-input/rollback/qemu-server/401.conf create mode 100644 src/test/snapshot-input/rollback/qemu-server/402.conf container: Thomas Lamprecht (8): config: add read-only meta property with the creation time fix #7846: config: add a guest identity to the 'meta' property api: migrate, clone: refuse targets that would drop the guest identity restore: take over the guest uid from the backup where possible restore: refuse overwriting a container with another guest's backup test: remote migration: check the cleanup of the target after failures api: remote migration: take over the guest uid from the source api: status: return the guest uid src/PVE/API2/LXC.pm | 177 ++- src/PVE/API2/LXC/Config.pm | 29 +- src/PVE/API2/LXC/Status.pm | 6 + src/PVE/CLI/pct.pm | 7 + src/PVE/LXC/Config.pm | 50 +- src/PVE/LXC/Migrate.pm | 31 +- src/test/Makefile | 8 +- src/test/config_tests.pl | 23 + src/test/lifecycle_tests.pl | 2092 +++++++++++++++++++++++++++++++++++ 9 files changed, 2388 insertions(+), 35 deletions(-) create mode 100755 src/test/lifecycle_tests.pl manager: Thomas Lamprecht (6): api: cluster resources: add guest uid and registration time api: cluster status: add cluster ID ui: restore: allow overwriting a guest with a backup of another guest ui: migrate: refuse target nodes that would drop the guest identity ui: guest summary: show the guest identity api: migrate all: refuse targets that would drop the guest identity PVE/API2/Cluster.pm | 24 ++- PVE/API2/Nodes.pm | 3 + test/ClusterResources_test.pl | 249 +++++++++++++++++++++++ test/ClusterStatus_test.pl | 114 +++++++++++ test/Makefile | 10 +- www/manager6/Makefile | 1 + www/manager6/panel/GuestIdentity.js | 142 +++++++++++++ www/manager6/panel/GuestStatusView.js | 3 + www/manager6/panel/TemplateStatusView.js | 3 + www/manager6/window/Migrate.js | 29 +++ www/manager6/window/Restore.js | 18 ++ 11 files changed, 594 insertions(+), 2 deletions(-) create mode 100755 test/ClusterResources_test.pl create mode 100755 test/ClusterStatus_test.pl create mode 100644 www/manager6/panel/GuestIdentity.js docs: Thomas Lamprecht (4): vzdump: describe the guest identity of VMs and containers pvecm: document the cluster ID and how to get a new one qm: configuration: describe the read-only meta property pct: configuration: describe the read-only meta property pct.adoc | 35 ++++++ pmxcfs.adoc | 1 + pvecm.adoc | 86 ++++++++++++++ qm.adoc | 38 +++++++ vzdump.adoc | 315 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 475 insertions(+) Summary over all repositories: 81 files changed, 9922 insertions(+), 122 deletions(-) -- 2.47.3