From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 771FF1FF0AA for ; Tue, 17 Nov 2026 21:40:28 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5E94B216CD; Tue, 17 Nov 2026 21:40:06 +0100 (CET) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage v3 03/51] common: use Exporter module for PVE::Storage::Common Date: Tue, 17 Nov 2026 21:38:35 +0100 Message-ID: <20261117203953.913035-4-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261117203953.913035-1-m.carrara@proxmox.com> References: <20261117203953.913035-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794947999789 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.278 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AGMMWYDKGTAYGF2H4X3VQ5CCOUQMYP5R X-Message-ID-Hash: AGMMWYDKGTAYGF2H4X3VQ5CCOUQMYP5R X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Wolfgang Bumiller X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Expose the existing helpers in `PVE::Storage::Common` via the `Exporter` module's `import()` function, allowing the helpers to be imported as-is by other modules. Signed-off-by: Max R. Carrara --- src/PVE/Storage/Common.pm | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/PVE/Storage/Common.pm b/src/PVE/Storage/Common.pm index aa3b5531..a784163e 100644 --- a/src/PVE/Storage/Common.pm +++ b/src/PVE/Storage/Common.pm @@ -5,10 +5,28 @@ use v5.36; use PVE::JSONSchema; use PVE::RPCEnvironment; use PVE::Syscall; use PVE::Tools qw(run_command); +use Exporter qw(import); + +our @EXPORT_OK = qw( + generic_vtype + is_guest_vtype + vtype_matches + content_allows + + align_size_up + deallocate + + qemu_img_create + qemu_img_create_qcow2_backed + qemu_img_info + qemu_img_measure + qemu_img_resize +); + use constant { FALLOC_FL_KEEP_SIZE => 0x01, # see linux/falloc.h FALLOC_FL_PUNCH_HOLE => 0x02, # see linux/falloc.h }; -- 2.47.3