From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 637471FF0AA for ; Tue, 17 Nov 2026 19:35:23 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 85F1621653; Tue, 17 Nov 2026 19:35:11 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox v2 02/11] network-api: add support for parsing interface flags Date: Tue, 17 Nov 2026 19:34:49 +0100 Message-ID: <20261117183500.750636-3-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261117183500.750636-1-s.hanreich@proxmox.com> References: <20261117183500.750636-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794940507257 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.263 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: KK7ODV7GEKWIXFC7Q5EW4UYDOVUNDXYZ X-Message-ID-Hash: KK7ODV7GEKWIXFC7Q5EW4UYDOVUNDXYZ X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Interface flags were not available in the parsed ip link output. The flags are required for determining the status of some interfaces, since WireGuard for example always sets the operating state to UNKNOWN, even if the interface is up and working. Signed-off-by: Stefan Hanreich --- proxmox-network-api/src/config/helper.rs | 22 ++++++++++++++++++++++ proxmox-network-api/src/config/mod.rs | 3 ++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/proxmox-network-api/src/config/helper.rs b/proxmox-network-api/src/config/helper.rs index 7feaaa51..d16adf76 100644 --- a/proxmox-network-api/src/config/helper.rs +++ b/proxmox-network-api/src/config/helper.rs @@ -172,6 +172,21 @@ pub enum Link { Unknown(UnknownLink), } +#[derive(Debug, Clone, Eq, PartialEq, Ord, PartialOrd, Hash, serde::Deserialize)] +#[serde(rename_all = "SCREAMING_SNAKE_CASE")] +pub enum LinkFlag { + Pointopoint, + Noarp, + Up, + LowerUp, + Broadcast, + Multicast, + Loopback, + Promisc, + #[serde(untagged)] + Unknown(String), +} + /// An IpLink entry, as returned by `ip -details -json link show`. /// /// For now this parses only the fields that are used throughout our stack, the fields of this @@ -187,6 +202,8 @@ pub struct IpLink { link_type: Link, linkinfo: Option, operstate: String, + #[serde(default)] + flags: Vec, } impl IpLink { @@ -256,6 +273,11 @@ impl IpLink { self.altnames.iter() } + /// Returns the flags of this interface + pub fn flags(&self) -> impl Iterator { + self.flags.iter() + } + /// Returns whether the interface is currently in an UP state. pub fn active(&self) -> bool { self.operstate == "UP" diff --git a/proxmox-network-api/src/config/mod.rs b/proxmox-network-api/src/config/mod.rs index 25ddd13f..9a9a0f07 100644 --- a/proxmox-network-api/src/config/mod.rs +++ b/proxmox-network-api/src/config/mod.rs @@ -3,7 +3,8 @@ mod lexer; mod parser; pub use helper::{ - AltnameMapping, IpLink, LinkInfo, assert_ifupdown2_installed, network_reload, parse_cidr, + AltnameMapping, IpLink, LinkFlag, LinkInfo, assert_ifupdown2_installed, network_reload, + parse_cidr, }; use std::collections::{BTreeMap, HashMap, HashSet}; -- 2.47.3