From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9D68F1FF0AA for ; Tue, 17 Nov 2026 16:28:47 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5D3EC216B8; Tue, 17 Nov 2026 16:28:35 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup/pxar 00/10] fix #8319: support split pxar archives in proxmox-backup-debug diff Date: Tue, 17 Nov 2026 16:28:04 +0100 Message-ID: <20261117152814.491323-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794929309723 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.372 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IKG5L3EOQFIVNA2LCINHWMU6AFEYKJYR X-Message-ID-Hash: IKG5L3EOQFIVNA2LCINHWMU6AFEYKJYR X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Support for split pxar archives has not yet been implemented for proxmox-backup-debug diff. This patch series fixes an encoding and decoding issues with entry ranges in pxar encountered during implementation and an off-by-one error for chunk lookup with range end in the current implementation of the archive diff, followed by some preliminary refactoring to ease subsequent implementation. Then support for the split meta-/ payload-data archives is added. For split pxar archives the goodbye table still incorrectly encoded the size to include the file payload size of a referenced file entry. It however is not part of the metadata archive, must therefore be excluded. The entry range is now trimmed to the actual range in the metadata archive, keeping backwards compatibility. Metadata and payload data index files are opened and compared like regular files, with a crucial difference: Since no changes in metadata archives do not necessarily imply no change in payload archive, the chunks for both are tracked independently, and contents changes are being checked even if the metadata chunks are unchanged, give the compare-contents flag. Link to the bugtracker: https://bugzilla.proxmox.com/show_bug.cgi?id=8319 pxar: Christian Ebner (3): encoder: record metadata-only goodbye size for split archive files accessor: limit split archive file entry ranges to payload reference accessor: add convenience helper to get content's byte range Cargo.toml | 6 ++ src/accessor/mod.rs | 39 ++++++-- src/encoder/mod.rs | 9 +- tests/split.rs | 220 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 265 insertions(+), 9 deletions(-) create mode 100644 tests/split.rs proxmox-backup: Christian Ebner (7): datastore: index: return dedicated type for chunk offset trait method bin: debug: fix off-by-one error in last chunk lookup bin: debug: refactore dynamic index reader opening logic into helper bin: debug: refactor and deduplicate chunk range difference check fix #8319: bin: debug: support split pxar archives via diff bin: debug: use pxar related archive name helpers for diff docs: debug: mention split pxar archives for diff subcommand docs/proxmox-backup-debug/description.rst | 5 +- pbs-datastore/src/cached_chunk_reader.rs | 9 +- pbs-datastore/src/dynamic_index.rs | 9 +- pbs-datastore/src/fixed_index.rs | 12 +- pbs-datastore/src/index.rs | 11 +- src/bin/proxmox_backup_debug/diff.rs | 299 ++++++++++++++++------ 6 files changed, 253 insertions(+), 92 deletions(-) Summary over all repositories: 10 files changed, 518 insertions(+), 101 deletions(-) -- Generated by murpp 0.11.0