From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C36A71FF0BC for ; Mon, 16 Nov 2026 14:31:50 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5F32321790; Mon, 16 Nov 2026 14:31:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794835882; x=1795440682; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aKNWSMGcp4u/wOeWEOQxjUYpc6+ZYFbMTQ3qT4BBw5E=; b=mSF/1NQbdNAa4UBywDZMWEMhNnNlgCe2T8uslrtElUn8xpdwA1+49VscbAo+Lt5pHf 5ccG9AAOoLxV9Y5l2FAGcevfC5/8eBr80mYm4HG8Wnjo4WHe1sAmE63OMtl3vpk2MrQw JmYi7DBGQjJCmcBQ93kif/91JPi17GTAspboF1O8dT4aiT3IzgT8wMKgB9yQ2xxeDxmS kI4m4xIXKX9O8hYiS+k7MWMlAckHCGlboUshBQmDdsMzz9mldqV47S+p5LbjDtnII+wb ZuLdTcIZNOVYtMMVQBPHvG9gZH+yf3mcw8s7CilZaB6YQHjRvKrDMXpnf1650z3YOgq2 s84g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794835882; x=1795440682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aKNWSMGcp4u/wOeWEOQxjUYpc6+ZYFbMTQ3qT4BBw5E=; b=a/LkpDQlZqpQXQBD3XV1uf4eKW9jM6sgLKzqMJbYCewM6a5DjaVYUqawn0IGGt79Jz qZhkfW+S9q4FYCynpu0YL+X5bkhwE0fdXwwhoe8Ubf+vM6Sg3dlINtH4FEqbP94gHpiA aA3Zqt3TKAOJ53AOpNAKPbu10iKDuNC97KjC0O6uT4MtWR+aay2t/yUWxIWP1FxNxmwG r9WfXwinn3f99z8MqPHNhPZKvG3WDahmdcdJb70yQzaapy9edlp+zOAqXyLB1RjU6adX PTJwwpH6DoVTsGpHqyTJdzLJNglimbqmpaAl+HV1te821dPQqDR9caS7IaE7RTFEyIjQ pyfw== X-Gm-Message-State: APuU4Z+xh/e+dt4QBpqNKn6hTAe4LY/gM66lDOBmagsunTWm0iO7nUBT YIFXzegGE7lUwI8bAlustH7Hhu7sSISFiRRIA7otb8bdzmY3LmuwESUxyfq1a1wk X-Gm-Gg: AZFdTZe2A3nGOp/Tp7K3X730wQ6PETDi9LxxIc/j+CoPLN1K9KMTpsKNOOo0VjssKfm 6rYAZJkrAwhHNfwhSBU+UjY95t80fE/OFcqQBQ0MjmtPsUkhFZsXssSz+T59jczyEO+ROPOPn1u mE6FbCbu//zVJxSg4nyqoCfD84dvSzF/KwUnxque0W9RY85gOCZtJPsZ1wGejzK32j0QXsRAOE9 GKT9H9+5ZExkzfoc0PXYjLODD10qn3h2j2RyYr7eCHzihPs2011HvFQYViRu5s5NGLLni08AiyK QJhu8I44Ak/BkxJMgcLvr5BzZQ9fZU+IA6a+NJTjODHsdVbc87KXIU23wkFdNYQkSR+MfilUEET 8k8FJTj2NqTyhmMc6CxBf7TT9z56wWFg90WkrGDlR9QABVam/+q7cZsIXiJ46rTR4VJGNA+4aIc 4TDvaJM0lPwJfsqoGiCYtp1ULpVMqpzWCqZ5Ny3mssW63xzYyq9tkuX11y6pWF7Dv4pV8G2e6KB K3/RNN2sT/3abzT4+eu4CeIOCWvk5gURaZH8BbvEUDnWZZS34ZNQ3p7Iw7I0rcDKV6Z89kRkugg zww0eJd2CCwng+UsEn5B12CnwZXvxUozbboaBahP/43P6H1SOt4lFkPzW+Mgpvucv6eMs+GTHn7 OeHCCbvEsjMjN6t/vrW2Q3iqb/V7Z9TpZdoHvcRImBFZC0jv2 X-Received: by 2002:a05:690c:e251:10b0:8b3:23f3:134d with SMTP id 00721157ae682-8b4aa2b33a1mr33363967b3.42.1794835881766; Mon, 16 Nov 2026 05:31:21 -0800 (PST) From: Lucas Barros To: pve-devel@lists.proxmox.com Subject: [PATCH manager v3 2/2] fix #6357: api: node dns: return all search domains Date: Mon, 16 Nov 2026 10:31:08 -0300 Message-ID: <20261116133000.6357-2-lucasbarros.kam@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20261116133000.6357-0-lucasbarros.kam@gmail.com> References: <20261116133000.6357-0-lucasbarros.kam@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.043 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SLWNAXR7L4BD4Y25N6YMIOAQSXKXRXIK X-Message-ID-Hash: SLWNAXR7L4BD4Y25N6YMIOAQSXKXRXIK X-MailFrom: lucasbarros.kam@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: t.lamprecht@proxmox.com, Lucas Barros X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The DNS settings of a node with multiple search domains could be written, but reading them back, for example in the node's DNS panel in the web UI, only showed the first domain, so saving the dialog again silently dropped the others. Use the new reader from pve-common that keeps the whole search list. The other users of the 'resolvconf' file, like the node certificate or the guest DNS fallback, keep getting only the first domain. Signed-off-by: Lucas Barros --- changes since v2: * new in v3: only the node DNS API switches to the whole search list * needs 1/2, so the libpve-common-perl dependency has to be bumped This patch was prepared with the help of an LLM based coding assistant; I reviewed the change and ran the tests from the cover letter myself. PVE/API2/Nodes.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm index 1e2a96f1..7f0b029d 100644 --- a/PVE/API2/Nodes.pm +++ b/PVE/API2/Nodes.pm @@ -1621,7 +1621,7 @@ __PACKAGE__->register_method({ code => sub { my ($param) = @_; - my $res = PVE::INotify::read_file('resolvconf'); + my $res = PVE::INotify::read_resolv_conf_with_search_list(); return $res; }, -- 2.50.1 (Apple Git-155)