From: Kefu Chai <k.chai@proxmox.com>
To: m.carrara@proxmox.com
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH ceph master/ceph squid/manager v4 0/7] Fix #6816: Prevent ceph-exporter Daemon from Crashing on Startup
Date: Mon, 16 Nov 2026 17:18:39 +0800 [thread overview]
Message-ID: <20261116091839.1804896-1-k.chai@proxmox.com> (raw)
In-Reply-To: <20260623134454.710441-1-m.carrara@proxmox.com>
Hi Max,
finally got around to this, sorry for the delay. I applied the
pve-manager patches to current master and they still apply cleanly,
which after five months is a pleasant surprise. I also like that the
keyring is only rewritten when its contents actually changed, and
that pve-init-ceph-crash comes down to a one-liner now.
Most of the comments below are about the ceph patches.
patch 3/7:
> + if test -n "$2" && dpkg --compare-versions "$2" 'lt' '9.2.4'; then
> + # Don't fail in case user has "exotic" configuration where RADOS
> + # isn't available on all nodes for some reason
> + /usr/share/pve-manager/helpers/pve-ceph-keyring --init client.exporter || true
> + fi
9.2.4 is long out by now, so for most people upgrading this branch
never triggers. I guess this wants a bump to whatever version the
series lands in.
Also, update_ceph_conf() restarts ceph-crash.service when it is
enabled. Maybe do the same here, otherwise an exporter that already
crash-looped into its start limit stays down even once the keyring is
there.
patch 6/7:
> +diff --git a/systemd/ceph-exporter.service.in b/systemd/ceph-exporter.service.in
Upstream renamed this to a template, ceph-exporter@.service.in, with
the Tentacle 20.2.4 import, so on current master this does not apply
anymore. The patches/series context moved as well, but that part is
just appending at the end again. The squid patch still has the right
file name.
Since the branch exists now, the series could use a tentacle-stable-9
patch too. With the template unit, --id being hardcoded to 'exporter'
means the instance name does not matter for the arguments, but
something still has to enable an instance. Does the packaging do
that? I did not dig into how the unit gets enabled these days.
One tiny nit on 5/7: #!/bin/bash can be #!/bin/sh for the one-liner.
And maybe a line for the commit message: the in-tree exporter never
talks to the cluster at all, it only scans the admin sockets, so the
mon 'allow r' cap is mostly there to have a valid key. Which I think
is fine, just good to know when someone later wonders about the caps.
next prev parent reply other threads:[~2026-11-16 9:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 13:44 [PATCH ceph master/ceph squid/manager v4 0/7] Fix #6816: Prevent ceph-exporter Daemon from Crashing on Startup Max R. Carrara
2026-06-23 13:44 ` [PATCH pve-manager v4 1/7] ceph: tools: add helper sub for creating or updating keyring files Max R. Carrara
2026-06-23 13:44 ` [PATCH pve-manager v4 2/7] fix #6816: api: ceph: create 'client.exporter' w/ keyring Max R. Carrara
2026-06-23 13:44 ` [PATCH pve-manager v4 3/7] fix #6816: bin: add pve-ceph-keyring helper and call it in postinst Max R. Carrara
2026-06-23 13:44 ` [PATCH pve-manager v4 4/7] ceph: tools: simplify helper sub for crash keyring file Max R. Carrara
2026-06-23 13:44 ` [PATCH pve-manager v4 5/7] bin: make pve-init-ceph-crash call pve-ceph-keyring Max R. Carrara
2026-06-23 13:44 ` [PATCH ceph master v4 6/7] fix #6816: patches: make ceph-exporter use custom keyring Max R. Carrara
2026-06-23 13:44 ` [PATCH ceph squid v4 7/7] " Max R. Carrara
2026-11-16 9:18 ` Kefu Chai [this message]
2026-11-16 11:15 ` [PATCH ceph master/ceph squid/manager v4 0/7] Fix #6816: Prevent ceph-exporter Daemon from Crashing on Startup Kefu Chai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116091839.1804896-1-k.chai@proxmox.com \
--to=k.chai@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.