From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH v2 manager 14/19] ui: token policy: expose the default-to-max-lifetime setting
Date: Sun, 15 Nov 2026 20:40:35 +0100 [thread overview]
Message-ID: <20261115194043.3947825-15-t.lamprecht@proxmox.com> (raw)
In-Reply-To: <20261115194043.3947825-1-t.lamprecht@proxmox.com>
Render and edit the new setting. It has no effect without a maximum
lifetime, so the checkbox is only enabled while one is entered and
gets cleared along with it.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
new in v2
www/manager6/dc/OptionView.js | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index 666be8a52..38b4e8d6e 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -401,6 +401,9 @@ Ext.define('PVE.dc.OptionView', {
);
parts.push(Ext.String.format(gettext('Max. Lifetime: {0}'), lifetime));
}
+ if (Number(policy['default-to-max-lifetime'])) {
+ parts.push(gettext('Default to Max. Lifetime'));
+ }
if (Number(policy['disallow-expiry-extension'])) {
parts.push(gettext('Disallow Extending Expiration'));
}
@@ -446,6 +449,9 @@ Ext.define('PVE.dc.OptionView', {
if (me.down('field[name=require-expiry]').getValue()) {
policy['require-expiry'] = 1;
}
+ if (values['default-to-max-lifetime']) {
+ policy['default-to-max-lifetime'] = 1;
+ }
if (values['disallow-expiry-extension']) {
policy['disallow-expiry-extension'] = 1;
}
@@ -500,9 +506,29 @@ Ext.define('PVE.dc.OptionView', {
requireExpiry.setValue(
implied || !!requireExpiry.explicitValue,
);
+ let defaultToMax = field
+ .up('inputpanel')
+ .down('field[name=default-to-max-lifetime]');
+ defaultToMax.setDisabled(!implied);
+ if (!implied) {
+ defaultToMax.setValue(false);
+ }
},
},
},
+ {
+ xtype: 'proxmoxcheckbox',
+ name: 'default-to-max-lifetime',
+ uncheckedValue: 0,
+ disabled: true,
+ fieldLabel: gettext('Default to Max. Lifetime'),
+ autoEl: {
+ tag: 'div',
+ 'data-qtip': gettext(
+ 'Give tokens created without an expiration date the maximum lifetime instead of rejecting them.',
+ ),
+ },
+ },
{
xtype: 'proxmoxcheckbox',
name: 'disallow-expiry-extension',
--
2.47.3
next prev parent reply other threads:[~2026-11-15 19:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 19:40 [PATCH v2 cluster/access-control/docs/manager/proxmox 0/19] fix #7805: add a datacenter-wide API token policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 cluster 1/19] datacenter config: add token-policy option Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 cluster 2/19] datacenter config: token policy: add default-to-max-lifetime setting Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 cluster 3/19] datacenter config: token policy: allow extension on regeneration Thomas Lamprecht
2026-11-17 13:30 ` Shannon Sterz
2026-11-15 19:40 ` [PATCH v2 access-control 4/19] fix #7805: api: token: enforce datacenter token policy Thomas Lamprecht
2026-11-17 13:30 ` Shannon Sterz
2026-11-15 19:40 ` [PATCH v2 access-control 5/19] api: token: apply the default lifetime from the " Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 access-control 6/19] api: token: allow extending tokens on secret regeneration Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 docs 7/19] user management: document the API token policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 docs 8/19] user management: document the default-to-max-lifetime setting Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 docs 9/19] user management: document extending tokens on secret regeneration Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 10/19] ui: token edit: only submit the expiration date when changed Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 11/19] api: cluster options: return token-policy without Sys.Audit Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 12/19] ui: dc options: allow editing the API token policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 manager 13/19] ui: token edit: adapt to the datacenter " Thomas Lamprecht
2026-11-15 19:40 ` Thomas Lamprecht [this message]
2026-11-15 19:40 ` [PATCH v2 manager 15/19] ui: token policy: allow extension on secret regeneration Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 proxmox 16/19] access-control: add API token policy type with expiry checks Thomas Lamprecht
2026-11-17 13:29 ` Shannon Sterz
2026-11-15 19:40 ` [PATCH v2 proxmox 17/19] access-control: enforce token policy on token create and update Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 proxmox 18/19] access-control: apply a default token lifetime from the policy Thomas Lamprecht
2026-11-15 19:40 ` [PATCH v2 proxmox 19/19] access-control: allow extending tokens on secret regeneration Thomas Lamprecht
2026-11-17 13:29 ` Shannon Sterz
2026-11-17 13:29 ` [PATCH v2 cluster/access-control/docs/manager/proxmox 0/19] fix #7805: add a datacenter-wide API token policy Shannon Sterz
2026-11-18 2:17 ` applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115194043.3947825-15-t.lamprecht@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.