From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id EA51D1FF0B7 for ; Fri, 13 Nov 2026 16:27:07 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A9157217C1; Fri, 13 Nov 2026 16:26:32 +0100 (CET) From: Dominik Rusovac To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES docs/ha-manager/manager v4 0/4] fix #6144: add api and ui for node maintenance mode Date: Fri, 13 Nov 2026 16:26:16 +0100 Message-ID: <20261113152620.2662417-1-d.rusovac@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794583585755 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.123 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ACZ46EMD3TGG4QE56EDLZJSP2MKZJ2GR X-Message-ID-Hash: ACZ46EMD3TGG4QE56EDLZJSP2MKZJ2GR X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: this picks up Thomas' v3 [0], rebased onto current master and reworked in a few places; thx for the nice work Thomas! I added `Originally-by` trailers node maintenance mode can currently only be enabled/disabled with the HA manager's CRM command in the CLI. this series adds an API endpoint and a 'Node Maintenance' menu in the HA status panel for it the endpoint lives at PUT /nodes/{node}/maintenance in pve-manager, as agreed on in the v1/v2 reviews, so that the maintenance concept can be extended beyond HA managed resources later on. for now, it just queues the same CRM command as the CLI. it rejects nodes unknown to the HA stack as well as enabling maintenance mode while HA is disarmed or if the node is not online from the CRM's point of view, since the CRM would ignore such requests to decide which action to offer, the UI uses the maintenance request recorded by the CRM, which the HA status API now reports, instead of the mode the LRM reports. the LRM also enters maintenance mode on shutdown with the 'migrate' shutdown policy, which a disable request cannot undo the UI patch (2/4) depends on the pve-ha-manager patch (3/4), as it uses the maintenance request reported by the HA status API, so pve-manager needs a bumped dependency on pve-ha-manager basic functionality was tested in a virtualized 3-node cluster: * enabling/disabling worked as expected * possible actions were offered as expected changes since v3: * rebase onto current master, including the arm/disarm changes, which also added a toolbar to the HA status panel * ha-manager: report the CRM maintenance request instead of the LRM mode * manager: api: check Sys.Modify on /nodes/{node} instead of /, reject nodes unknown to HA, and reject enabling maintenance while HA is disarmed or if the node is not online * manager: ui: move the menu next to Arm/Disarm, use the view model and controller of the HA status panel, fix selection handling, use complete sentences for translatable strings, show a spinner while a maintenance request is processed * docs: condense the UI instructions and adapt them to the menu [0] https://lore.proxmox.com/all/20251025183814.698627-1-thomas@atskinner.net/ pve-manager: Dominik Rusovac (2): api: nodes: add endpoint to set maintenance mode fix #6144: ui: ha: status: allow toggling maintenance mode PVE/API2/Nodes.pm | 54 ++++++++++++++++++ www/manager6/ha/Status.js | 102 ++++++++++++++++++++++++++++++++++ www/manager6/ha/StatusView.js | 36 +++++++++++- 3 files changed, 191 insertions(+), 1 deletion(-) pve-ha-manager: Dominik Rusovac (1): api: status: report node maintenance request for lrm entries src/PVE/API2/HA/Status.pm | 10 ++++++++++ 1 file changed, 10 insertions(+) pve-docs: Dominik Rusovac (1): ha-manager: maintenance mode: mention web ui menu ha-manager.adoc | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) Summary over all repositories: 5 files changed, 210 insertions(+), 7 deletions(-) -- Generated by murpp 0.11.0