From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox v4 06/11] s3-client: add additional backoff delay between upload retries
Date: Fri, 13 Nov 2026 15:21:43 +0100 [thread overview]
Message-ID: <20261113142148.569471-7-c.ebner@proxmox.com> (raw)
In-Reply-To: <20261113142148.569471-1-c.ebner@proxmox.com>
Uploads are repeated immediately if the server reports a conflicting
concurrent operation on the same object. Retrying right away gives a
concurrent operation no time to finish and adds load to a server
which already failed to handle the request.
Wait for the jittered transient backoff before repeating the upload,
as done for the individual requests.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
proxmox-s3-client/src/client.rs | 1 +
1 file changed, 1 insertion(+)
diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs
index c4fb2733..12d9a206 100644
--- a/proxmox-s3-client/src/client.rs
+++ b/proxmox-s3-client/src/client.rs
@@ -1027,6 +1027,7 @@ impl S3Client {
}
}
}
+ tokio::time::sleep(retry_backoff_with_jitter(RetryReason::Transient, retry)).await;
}
Ok(false)
}
--
2.47.3
next prev parent reply other threads:[~2026-11-13 14:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 14:21 [PATCH proxmox{,-backup} v4 00/11] fix #7606: verify: s3: handle transient fetch errors and add retry Christian Ebner
2026-11-13 14:21 ` [PATCH proxmox v4 01/11] s3-client: also retry requests on bad gateway responses Christian Ebner
2026-11-13 14:21 ` [PATCH proxmox v4 02/11] s3-client: distinguish transient errors and throttled requests Christian Ebner
2026-11-13 14:21 ` [PATCH proxmox v4 03/11] s3-client: detect throttling request from the response body on error Christian Ebner
2026-11-13 14:21 ` [PATCH proxmox v4 04/11] s3-client: avoid retry bursts by adding jitter to retry backoff delay Christian Ebner
2026-11-13 14:21 ` [PATCH proxmox v4 05/11] s3-client: honor response header directed retry delays Christian Ebner
2026-11-13 14:21 ` Christian Ebner [this message]
2026-11-13 14:21 ` [PATCH proxmox v4 07/11] s3-client: add helper to fetch object contents with retry Christian Ebner
2026-11-13 14:21 ` [PATCH proxmox-backup v4 08/11] s3: retry fetching object contents on body collection errors Christian Ebner
2026-11-13 14:21 ` [PATCH proxmox-backup v4 09/11] datastore: snapshot: propagate errors in manifest update callback Christian Ebner
2026-11-13 14:21 ` [PATCH proxmox-backup v4 10/11] fix #7606: verify: s3: handle transient chunk load errors Christian Ebner
2026-11-13 14:21 ` [PATCH proxmox-backup v4 11/11] verify: s3: stop early if the endpoint appears unreachable Christian Ebner
2026-11-16 9:55 ` superseded: [PATCH proxmox{,-backup} v4 00/11] fix #7606: verify: s3: handle transient fetch errors and add retry Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113142148.569471-7-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.