From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A5BD21FF0B7 for ; Fri, 13 Nov 2026 15:21:55 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3EDC0215C2; Fri, 13 Nov 2026 15:21:55 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox v4 01/11] s3-client: also retry requests on bad gateway responses Date: Fri, 13 Nov 2026 15:21:38 +0100 Message-ID: <20261113142148.569471-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261113142148.569471-1-c.ebner@proxmox.com> References: <20261113142148.569471-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794579711770 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.752 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: YXPRHP3B4Z3ANXE7AIQG3ASHKUAYI2CL X-Message-ID-Hash: YXPRHP3B4Z3ANXE7AIQG3ASHKUAYI2CL X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A bad gateway response is typically returned by proxies or load balancers sitting in front of the S3 compatible object store if the latter is temporarily not reachable. This is not as frequent as already retried status codes, but should be retried as well. Since such a status code signals a transient failure, add it to the list of retriable responses. Signed-off-by: Christian Ebner --- proxmox-s3-client/src/client.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs index 6a87bd0c..3f2a7107 100644 --- a/proxmox-s3-client/src/client.rs +++ b/proxmox-s3-client/src/client.rs @@ -510,6 +510,7 @@ impl S3Client { Ok(response) => matches!( response.status(), StatusCode::INTERNAL_SERVER_ERROR + | StatusCode::BAD_GATEWAY | StatusCode::SERVICE_UNAVAILABLE | StatusCode::GATEWAY_TIMEOUT | StatusCode::TOO_MANY_REQUESTS -- 2.47.3