From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 733211FF0B7 for ; Fri, 13 Nov 2026 10:06:38 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7913221808; Fri, 13 Nov 2026 10:06:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stuttgart.de; s=s1022; t=1794560286; bh=DauWEwFTuWI+yWYiGEHMYJ1NDF2LRkFKHtFFxXyiYVg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0s5caYcfT8sphwmQL+EDUqtrm63hA9soZwAEHe1wI4AuRyCqvwO90/b+9tiCdrJi4 +OvMOeJUZJqC9sPmyds7SeC+voV81PjandnunfC4CrvIzeX6PhtcdryuBGrvtPynwU TVXqc+bBkmf7Co/uqy2Wyr9JJMrVpUeo8lgrzaGxvcZwoo0EnB1ns2tYk9Nhddx/IQ 3fGRZfE4OxyNxLTr+TvSuGw4XFJSoFyLeo/tAnfwTJrnb54t78wPbxW5bQdiOrU+/u z+7HQ91wmt/vBY09w1DehGn0arH+yNJQnMiWwIVoj2FNArrxK8ITth8w8LTk80cC5P /ELKBde/Dmu1g== From: Jakob-Tobias Winter To: pbs-devel@lists.proxmox.com Subject: [RFC PATCH guest-common 09/12] vzdump: add pbs-snapshot-attributes option Date: Fri, 13 Nov 2026 09:56:36 +0100 Message-ID: <20261113085637.57360-12-tobias@stuttgart.de> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261113085637.57360-3-tobias@stuttgart.de> References: <20261113085637.57360-3-tobias@stuttgart.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TDBXMXCMI535VQM552YBDM2R5ZBKKHDG X-Message-ID-Hash: TDBXMXCMI535VQM552YBDM2R5ZBKKHDG X-MailFrom: prvs=d19b210678=tobias@stuttgart.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jakob-Tobias Winter X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Backups to a Proxmox Backup Server will store the tags and the resource pool of a guest as attributes of the backup snapshot, so that the server can select backups by them, for example in tape backup jobs. The attributes are stored unencrypted, also for encrypted backups, and everyone with access to the backup snapshot on the server can read them. Tags and pool names can reveal more about a setup than its admin wants the backup server to know, so add an option to turn this off. It can be set for single jobs and, as default for all backups of a node, in /etc/vzdump.conf. The option is enabled by default, so that selecting backups by tag works without changing every job. Signed-off-by: Jakob-Tobias Winter --- src/PVE/VZDump/Common.pm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm index 2cb48a3..7a87c45 100644 --- a/src/PVE/VZDump/Common.pm +++ b/src/PVE/VZDump/Common.pm @@ -384,6 +384,14 @@ my $confdesc = { optional => 1, enum => ['legacy', 'data', 'metadata'], }, + 'pbs-snapshot-attributes' => { + type => 'boolean', + description => "Store the tags and the resource pool of the guest as attributes of the" + . " backup snapshot on a Proxmox Backup Server. The attributes are not encrypted and" + . " can be read by everyone with access to the backup snapshot.", + optional => 1, + default => 1, + }, }; sub get_confdesc { base-commit: 3d32b926e7664f095611d7192944926ebdd5ca14 -- 2.53.0