From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0CCBE1FF0B7 for ; Fri, 13 Nov 2026 04:36:59 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0D9E821E15; Fri, 13 Nov 2026 04:22:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wolfssl-com.20260707.gappssmtp.com; s=20260707; t=1794539209; x=1795144009; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=8ebkdFdD0AFb875soqzKxaSUfqBvrrouMR76X/5ROOo=; b=oCYB+yyhd11ddH1Hjs70zFNoOe7KxAcr1u5h/YsF5r9a+N34bWAQB4NWXD2eD9dSdY 5IWM9ccXqkps/dYAQbStMY95RVEk1u/alC2b/hVGf8lXl5yxkVUeqbTARyt6+z1ADjFI 7ljGIdPFhc4KOzpKZeVIzCkTi/+8CTvnKqnwjfieWPGuK2C0vFD32gs69w8rK7GBbiSd JdMYINJcA8NLkET3u5rIdWmayL9bodfeZ7Xn5BsprWhYfPhYBF5KLaIqLYdv07HufgIn x7NLJT3c5YyA5zsAWrIzfvnmwocHlnPk4GioH5AhFkIlI7eZCYcs8cuKUwYeCFuoT6zv E+cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794539209; x=1795144009; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=8ebkdFdD0AFb875soqzKxaSUfqBvrrouMR76X/5ROOo=; b=cIAB+cVFA5DVHI9Zuok3wNUS9wZb+5GAirn3ez9TDxB2QyyTRDKgb7s6QsRHPZry1W 3Wx5tDcUOhWOo9KJ0uaFKCHInirrBFFooQzISBEvy4ORfunnoXciVqsXmm7Bkr47tLj/ ej1hSA5+o4Qj3tEiP+ryOdwAcHBAZ3ZgpMgSNL0HpqBPZsr+HLd5Gmxe0JX78y8/ydVC iDSBtwnkFaujC2OocorW1EpG8ZWAKqzvSdK2dWryYBQtvI5iWIpiIxkORC42psStPDJO 2/jRJxkwpKJr40cpPoktlzoOHYftWATGYl/l5pskZ5hr5t+WwW5GY7SM/PKEzYm7Yebm 5AiA== X-Gm-Message-State: APuU4Z+WK/BaBGOFvP7JtBVJtkSrTA8tzYb5Pzo9rzi4vw7sF8lgpV/f DrTuuozI0R3oytcdGDLMt30TS4k4e527z7sPJuXshmu6gdfC1PNT+hUAJs+dkjQODdvAohJUQPV c5Uvm X-Gm-Gg: AYBFou0BwmrrqvK3pj1QYsxOssBq6oaRWl1BOixoLGJIo9JHEKJyiwK7b3Yb9hl3Dyt skAjCvOHP8q5NqMHZhP/QItpw9VswqTzp/PuiGYoESXpILf+FXl806+KoFmyuoR9Z85e7pDyVke ShrWWG1pk/hokiD8uMtqxkTb3Ai3kb9Brj7KSZNqkipcI21+Dvqw40ybXVqRL3CnAFmRo6LjV29 kWaa6KI3Ife7rSH3C2oYycMDpH+G4T2SFPJU+QFv9ZR/KYc3ZYeZTjazTFEi9RCUuQAQfDTssnB Q9yGqujTf5Ufx2npIasDMfDqMl3W8QlmskU3o35SMeRWqFZiQ92y4zFPrSXMKZ84I8mj9a2tuid c50QHOM5pjPW1jorEdDo1k7Zc4jiotA4HoifcZ/UianwjiuKflJzem69/rBQreuW6oRrqa/0Art wOWGK2QeYy4ML4lq+bm/X7n0lqmDIs8AFupwVdSxFWcdEzEtkFjhuwSgVoCM7fW+Rbi2wWpaQBa skmG0mvFh7zMRuFifXMouFIifrm03+b0XqgxNNHmQjAzKKVRvN8sbusKX7Vaa0RGh88FmxtznI+ 9y8TxVLVNxVK5RyFUfL7WZs+D0PXoCeFxHqB7pQTlPIqAwjfe7oxE2disCoTtzgwyjUqcUd+791 eym+lD/mrzurMQFqcAhMbJIY9MLECHYWgQzwj+X0CnGqxwHTwgv1hGbb6HdB1/QQ//Ne39DadpC hqRv+sevIfv79f18fRg8/qqIo5OWlsKF5AOXyA1x+KieF/Fr0r5158SbNnYSTJxmaBTcuEN+m9w 8r+kXE5hA== X-Received: by 2002:a05:6830:4c18:b0:844:ce0e:e43 with SMTP id 46e09a7af769-8628991bca3mr1092703a34.29.1794539209332; Thu, 12 Nov 2026 19:06:49 -0800 (PST) From: Mark Atwood To: pve-devel@lists.proxmox.com Subject: [PATCH cluster v2 0/1] datacenter config: add ticket-signature-hash option Date: Fri, 13 Nov 2026 03:06:45 +0000 Message-ID: <20261113030646.3533-1-mark@wolfssl.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DMARC_PASS -0.1 DMARC pass policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: GRTLZ3BHLG4CWWL5FOT3BW4CI4HUD4EY X-Message-ID-Hash: GRTLZ3BHLG4CWWL5FOT3BW4CI4HUD4EY X-MailFrom: mark@wolfssl.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add a cluster-wide datacenter.cfg option 'ticket-signature-hash' (sha1 or sha256, default sha1) for the hash of the RSA signature of newly created authentication tickets. pve-access-control reads it, see that patch. It exists so that setups where SHA-1 signatures are not acceptable, e.g. FIPS mode, can enable SHA-256 signed tickets now. Nothing changes by default. This is the pve-cluster part of the v2 of "ticket: sign RSA tickets with SHA-256". The pve-common part also affects Proxmox Mail Gateway, which uses PVE::Ticket; this option does not affect PMG. Apply order across the repositories, all three are part of this series: 1. pve-common (2 patches) 2. pve-cluster (adds the datacenter.cfg option) 3. pve-access-control (reads the option and signs with it) pve-common and pve-cluster are independent of each other. pve-access-control needs both, but is harmless without them: it then keeps signing with SHA-1. Mixed clusters: nodes without pve-common 1/2 reject SHA-256 tickets, so the option must only be set to 'sha256' once every node has that patch. The option description says so. I did not add an automatic check against the node versions (the new helpers in pve-cluster, 679cf2c, would allow one), as it needs the release number that will contain 1/2. Happy to add one in pve-manager's datacenter options update once that number is known. Changes since v1: the option is new in v2. v1 switched signing to SHA-256 unconditionally, with an environment variable for the transition. Shannon asked for opt-in, so FIPS users can enable it now, and a cluster-wide datacenter.cfg option with default off was chosen. It is a plain enum, as the hyphenated names of the newer options ('next-id', 'tag-style') suggest, and leaves room for more hashes. The other v1 review points are in the pve-common cover letter. v1: This is sent as a new thread, as is usual for a new version of a series. Thanks to Shannon Sterz for the review of v1. Mark Atwood (1): datacenter config: add ticket-signature-hash option src/PVE/DataCenterConfig.pm | 16 +++++++++++ src/test/Makefile | 6 ++++- src/test/test_ticket_signature_hash.pl | 37 ++++++++++++++++++++++++++ 3 files changed, 58 insertions(+), 1 deletion(-) create mode 100644 src/test/test_ticket_signature_hash.pl base-commit: 679cf2c674254f41ddd89cc8e4e17d83c8444ad7