From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 995B01FF0B7 for ; Fri, 13 Nov 2026 04:16:24 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DB02621B31; Fri, 13 Nov 2026 04:05:15 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v4 manager 36/36] ui: storage: point the iSCSI and LVM add dialogs to the SAN view Date: Fri, 13 Nov 2026 04:00:54 +0100 Message-ID: <20261113030146.1559030-37-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261113030146.1559030-1-t.lamprecht@proxmox.com> References: <20261113030146.1559030-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794538915963 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.238 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: SVHJ2N4KQVHWMRHVG64IYWKIANFMDQ3G X-Message-ID-Hash: SVHJ2N4KQVHWMRHVG64IYWKIANFMDQ3G X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Admins new to Proxmox VE look for adding their SAN under Datacenter > Storage > Add. There, the iSCSI dialog connects a target without a volume group on top and, by default, without multipath, so they end up with neither a storage that can allocate guest disks nor path redundancy. The guided setups that do both are in the SAN view, which nothing in these dialogs mentions. Add a note to the add dialogs of iSCSI and LVM that names the SAN view. Its link closes the dialog and opens the view. The dialogs stay as they are for attaching existing targets and volume groups. The storage panel base shows the note for panels that set one, so the NVMe over Fabrics dialog can use it as well. Signed-off-by: Thomas Lamprecht --- www/manager6/SANUtils.js | 38 +++++++++++++++++++++++++++++++ www/manager6/storage/Base.js | 5 ++++ www/manager6/storage/IScsiEdit.js | 3 +++ www/manager6/storage/LVMEdit.js | 3 +++ 4 files changed, 49 insertions(+) diff --git a/www/manager6/SANUtils.js b/www/manager6/SANUtils.js index 8947d83e5..c08ac2a1a 100644 --- a/www/manager6/SANUtils.js +++ b/www/manager6/SANUtils.js @@ -103,6 +103,44 @@ Ext.define('PVE.SANUtils', { return Ext.htmlEncode(PVE.SANUtils.usageText(rec.data)); }, + // Selects Datacenter > Storage > SAN, as the TFA entry of the user menu does for its panel. + showSANView: function () { + Ext.state.Manager.getProvider().set('dctab', { value: 'san' }, true); + Ext.ComponentQuery.query('pveStdWorkspace')[0]?.selectById('root'); + }, + + // A note for the add dialogs of storages on a SAN, which points to the guided setups of the + // SAN view. Its link closes the dialog and opens the view. + sanViewNote: function (text) { + let path = `${gettext('Datacenter')} > ${gettext('Storage')} > SAN`; + let link = `${Ext.htmlEncode(path)}`; + return { + xtype: 'component', + margin: '5 0 0 0', + html: + `${Ext.htmlEncode(gettext('Note:'))} ` + + Ext.String.format(Ext.htmlEncode(text), link), + listeners: { + afterrender: function (cmp) { + let follow = function (event) { + event.stopEvent(); + cmp.up('window')?.close(); + PVE.SANUtils.showSANView(); + }; + cmp.mon(cmp.getEl(), 'click', follow, null, { delegate: 'a' }); + // an edit window handles Enter for its default button, so no click follows it + cmp.mon( + cmp.getEl(), + 'keydown', + (event) => event.getKey() === event.ENTER && follow(event), + null, + { delegate: 'a' }, + ); + }, + }, + }; + }, + renderSanTransport: function (value) { return Ext.htmlEncode( { diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js index 04f5f706f..58e77c05c 100644 --- a/www/manager6/storage/Base.js +++ b/www/manager6/storage/Base.js @@ -131,6 +131,11 @@ Ext.define('PVE.panel.StorageBase', { me.advancedColumnB.unshift(volumeChain.hint); } + // the add dialog of a SAN storage points to the guided setups of the SAN view + if (me.isCreate && me.sanNote) { + me.columnB = [...(me.columnB ?? []), PVE.SANUtils.sanViewNote(me.sanNote)]; + } + me.callParent(); }, }); diff --git a/www/manager6/storage/IScsiEdit.js b/www/manager6/storage/IScsiEdit.js index 0725edad0..f11995585 100644 --- a/www/manager6/storage/IScsiEdit.js +++ b/www/manager6/storage/IScsiEdit.js @@ -75,6 +75,9 @@ Ext.define('PVE.storage.IScsiInputPanel', { onlineHelp: 'storage_open_iscsi', + // TRANSLATORS: "Add Storage" is a button of the SAN view, {0} the menu path of that view. + sanNote: gettext('To set up shared LVM with multipath on a LUN, use Add Storage in {0}.'), + // Loading sets the value before its original value, so use the dirty state. updateMultipathActivation: function () { let me = this; diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js index 0c56455df..9c4df2609 100644 --- a/www/manager6/storage/LVMEdit.js +++ b/www/manager6/storage/LVMEdit.js @@ -148,6 +148,9 @@ Ext.define('PVE.storage.LVMInputPanel', { onlineHelp: 'storage_lvm', + // TRANSLATORS: "Add Storage" is a button of the SAN view, {0} the menu path of that view. + sanNote: gettext('To set up shared LVM on a SAN LUN, use Add Storage in {0}.'), + column1: [ { xtype: 'pveBaseStorageSelector',