From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 36FDB1FF0B7 for ; Fri, 13 Nov 2026 04:12:22 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D69CA21A17; Fri, 13 Nov 2026 04:05:06 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v4 manager 30/36] ui: lvm: enable shared when a base storage is selected Date: Fri, 13 Nov 2026 04:00:48 +0100 Message-ID: <20261113030146.1559030-31-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261113030146.1559030-1-t.lamprecht@proxmox.com> References: <20261113030146.1559030-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794538915595 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.242 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: B3T3XWNHJ3BKLYJF3GCSLQK362JMWJ4V X-Message-ID-Hash: B3T3XWNHJ3BKLYJF3GCSLQK362JMWJ4V X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A volume group on a LUN of a base storage is reachable from every node that uses that storage. Without the shared flag each node handles it as a local volume group of its own: allocations are only serialized per node, and a migration treats the disks as local ones that have to be copied. The checkbox is off by default and easy to miss. Enable it when a base storage gets selected, and disable it again for an existing volume group, where it was off before. It can still be changed afterwards. Signed-off-by: Thomas Lamprecht --- www/manager6/storage/LVMEdit.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js index 148f0601c..0c56455df 100644 --- a/www/manager6/storage/LVMEdit.js +++ b/www/manager6/storage/LVMEdit.js @@ -174,6 +174,9 @@ Ext.define('PVE.storage.LVMInputPanel', { vgNameField.setVisible(!!value); vgNameField.setDisabled(!value); + + // a LUN of a base storage is reachable from all nodes of that storage + me.up('inputpanel').down('field[name=shared]').setValue(!!value); }, }, },