From: Ciro Iriarte <cyruspy@gmail.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH storage] btrfs: fix clone_image cloning live data instead of the requested snapshot
Date: Fri, 13 Nov 2026 15:43:56 -0300 [thread overview]
Message-ID: <20261113.btrfsclonesnapfix.ping@cyruspy.gmail.com> (raw)
In-Reply-To: <20260907.btrfsclonesnapfix@cyruspy.gmail.com>
Ping. This patch is independent of the copy-offload series.
BTRFSPlugin::clone_image() accepts $snap but never passes it to
filesystem_path(), so it always clones the live subvolume. As a result,
linked-cloning a raw disk from a snapshot on btrfs storage silently
produces a disk with the current data instead of the snapshot's.
It is reachable through the clone API with full=0 and snapname, e.g.
qm clone <vmid> <newid> --full 0 --snapname <snapshot>. The commit
message overstates this: the GUI does not offer that combination.
The bug is still present on current master (76a5d40), and the patch
still applies cleanly. It is filed as bug #8156.
prev parent reply other threads:[~2026-11-13 18:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 5:06 [PATCH storage] btrfs: fix clone_image cloning live data instead of the requested snapshot Ciro Iriarte
2026-11-13 18:43 ` Ciro Iriarte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261113.btrfsclonesnapfix.ping@cyruspy.gmail.com \
--to=cyruspy@gmail.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.