From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id EE7CD1FF0B6 for ; Thu, 12 Nov 2026 15:16:04 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5EEE82164B; Thu, 12 Nov 2026 15:16:00 +0100 (CET) From: Filip Schauer To: pve-devel@lists.proxmox.com Subject: [PATCH storage 20/26] api: oci image pull: fix temp file cleanup on task stop Date: Thu, 12 Nov 2026 15:10:47 +0100 Message-ID: <20261112141109.137298-21-f.schauer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261112141109.137298-1-f.schauer@proxmox.com> References: <20261112141109.137298-1-f.schauer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794492957003 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.175 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PB5SCANBUMPQN3Q5KBTUJZSHE4CRP65P X-Message-ID-Hash: PB5SCANBUMPQN3Q5KBTUJZSHE4CRP65P X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The $SIG{INT} handler was installed in the parent process before fork_worker() forks the actual worker child. fork_worker() overwrites $SIG{INT}/TERM/QUIT in the child with its own handler before invoking the worker sub, so the cleanup handler never ran and interrupted pulls left the temporary file behind. Move the handler into the worker and also catch SIGTERM, since that is the signal actually sent when a task is stopped. Signed-off-by: Filip Schauer --- src/PVE/API2/Storage/Status.pm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.pm index 8812d47..332e06d 100644 --- a/src/PVE/API2/Storage/Status.pm +++ b/src/PVE/API2/Storage/Status.pm @@ -976,14 +976,14 @@ __PACKAGE__->register_method({ die "refusing to override existing file '$filename'\n" if -f "$path/$filename"; - local $SIG{INT} = sub { - unlink "$path/$tmp_filename" - or $!{ENOENT} - or warn "could not cleanup temporary file: $!"; - die "got interrupted by signal\n"; - }; - my $worker = sub { + local $SIG{INT} = local $SIG{QUIT} = local $SIG{TERM} = sub { + unlink "$path/$tmp_filename" + or $!{ENOENT} + or warn "could not cleanup temporary file: $!"; + die "got interrupted by signal\n"; + }; + PVE::RS::OCI::pull_image_as_tar($reference, "Anonymous", "$path/$tmp_filename"); rename("$path/$tmp_filename", "$path/$filename") or die "unable to rename temporary file: $!\n"; -- 2.47.3