From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D426C1FF0B6 for ; Thu, 12 Nov 2026 12:51:25 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 92B5321802; Thu, 12 Nov 2026 12:50:16 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH container v7 17/32] migrate: call prepare_local_cluster_checks() method Date: Thu, 12 Nov 2026 12:48:49 +0100 Message-ID: <20261112115001.107306-18-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261112115001.107306-1-f.ebner@proxmox.com> References: <20261112115001.107306-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794484205829 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.269 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: N3Y55FW74SHH2CJQXBGVKYUPZYKRF6GJ X-Message-ID-Hash: N3Y55FW74SHH2CJQXBGVKYUPZYKRF6GJ X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Factoring out the common SSH check and in preparation for checking that the configuration can be parsed on the target. Signed-off-by: Fiona Ebner --- Dependency bump for guest-common needed! New in v7. src/PVE/LXC/Migrate.pm | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 04133f4..f7a4ec0 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/PVE/LXC/Migrate.pm @@ -167,10 +167,7 @@ sub prepare { $self->log('info', "websocket tunnel started\n"); $self->{tunnel} = $tunnel; } else { - # test ssh connection - my $cmd = [@{ $self->{rem_ssh} }, '/bin/true']; - eval { $self->cmd_quiet($cmd); }; - die "Can't connect to destination address using public key\n" if $@; + $self->prepare_local_cluster_checks(); } # in restart mode, we shutdown the container before migrating -- 2.47.3