all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [RFC PATCH qemu-server] config: watchdog: remove unusable model
Date: Wed, 11 Nov 2026 14:49:36 +0100	[thread overview]
Message-ID: <20261111135237.2666585-1-d.csapak@proxmox.com> (raw)

Since commit 0a40e8ea (fix watchdog pci addr) from 2011 (!), the `ib700`
model of the virtual watchdog hardware was unusable, since we always
want to attach it to a pci bus, but that model is an ISA variant so QEMU
fails to start with:

  kvm: -device ib700,bus=pci.0,addr=0x4: Device 'ib700' can't go on PCI bus

Instead of trying to fix it, just remove this model, since there was no
report in the last 15 years, so nobody seems to be interested in it.

The default model is a PCI variant, so this works as expected.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
i didn't add a "Fixes" trailer on purpose, since it does not "fix" a
commit in the normal sense, but prevents configuring non-working
settings.

 src/PVE/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index 005fcb6e..55abde5e 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -147,7 +147,7 @@ my $watchdog_fmt = {
     model => {
         default_key => 1,
         type => 'string',
-        enum => [qw(i6300esb ib700)],
+        enum => [qw(i6300esb)],
         description => "Watchdog type to emulate.",
         default => 'i6300esb',
         optional => 1,
-- 
2.47.3





             reply	other threads:[~2026-11-11 13:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-11 13:49 Dominik Csapak [this message]
2026-11-11 22:57 ` applied: [RFC PATCH qemu-server] config: watchdog: remove unusable model Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261111135237.2666585-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal