[PATCH pve-manager v6 21/28] ui: firewall: aliases: add controls for dangling references

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

Add the shared dangling-references action selector to the update dialog
and replace the plain remove button with a confirmation dialog carrying
the same selector to let users choose how to handle dangling references
on config changes.

'force-rename' is not offered. It is meant as an escape hatch to recover
from a partially applied rename, putting it next to the normal actions
makes it too easy to select.

StdRemoveButton cannot pass the extra 'dangling-references' parameter,
so the remove button is switched to a plain button that opens the
shared FirewallObjectRemove dialog.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/grid/FirewallAliases.js | 121 ++++++++++++++++++++++-----
 1 file changed, 99 insertions(+), 22 deletions(-)

diff --git a/www/manager6/grid/FirewallAliases.js b/www/manager6/grid/FirewallAliases.js
index 06801d33..06dc3b9c 100644
--- a/www/manager6/grid/FirewallAliases.js
+++ b/www/manager6/grid/FirewallAliases.js
@@ -7,6 +7,8 @@ Ext.define('PVE.FirewallAliasEdit', {
 
     width: 400,
 
+    onlineHelp: 'pve_firewall_dangling_references',
+
     initComponent: function () {
         let me = this;
 
@@ -20,27 +22,68 @@ Ext.define('PVE.FirewallAliasEdit', {
             me.method = 'PUT';
         }
 
+        let items = [
+            {
+                xtype: 'textfield',
+                name: me.isCreate ? 'name' : 'rename',
+                fieldLabel: gettext('Name'),
+                allowBlank: false,
+            },
+            {
+                xtype: 'textfield',
+                name: 'cidr',
+                fieldLabel: gettext('IP/CIDR'),
+                allowBlank: false,
+            },
+            {
+                xtype: 'textfield',
+                name: 'comment',
+                fieldLabel: gettext('Comment'),
+            },
+        ];
+        let advancedItems = [];
+        if (!me.isCreate) {
+            advancedItems.push({
+                xtype: 'pveFirewallReferenceAction',
+                preferredValue: 'rename',
+                referenceActions: [
+                    {
+                        text: gettext('Keep'),
+                        value: 'keep',
+                        description: gettext(
+                            'Do not touch firewall rules and IPSet members referencing this alias.',
+                        ),
+                    },
+                    {
+                        text: gettext('Disable'),
+                        value: 'disable',
+                        description: gettext(
+                            'Disable firewall rules and delete IPSet members referencing this alias.',
+                        ),
+                    },
+                    {
+                        text: gettext('Delete'),
+                        value: 'drop',
+                        description: gettext(
+                            'Delete firewall rules and IPSet members referencing this alias.',
+                        ),
+                    },
+                    {
+                        text: gettext('Rename'),
+                        value: 'rename',
+                        description: gettext(
+                            'Rewrite referencing firewall rules and IPSet members to point to the new alias name.',
+                        ),
+                    },
+                ],
+            });
+        }
+
         let ipanel = Ext.create('Proxmox.panel.InputPanel', {
             isCreate: me.isCreate,
-            items: [
-                {
-                    xtype: 'textfield',
-                    name: me.isCreate ? 'name' : 'rename',
-                    fieldLabel: gettext('Name'),
-                    allowBlank: false,
-                },
-                {
-                    xtype: 'textfield',
-                    name: 'cidr',
-                    fieldLabel: gettext('IP/CIDR'),
-                    allowBlank: false,
-                },
-                {
-                    xtype: 'textfield',
-                    name: 'comment',
-                    fieldLabel: gettext('Comment'),
-                },
-            ],
+            items,
+            // an empty array would still turn on the 'Advanced' checkbox
+            advancedItems: advancedItems.length ? advancedItems : undefined,
         });
 
         Ext.apply(me, {
@@ -158,15 +201,49 @@ Ext.define('PVE.FirewallAliases', {
             },
         });
 
-        me.removeBtn = Ext.create('Proxmox.button.StdRemoveButton', {
+        me.removeBtn = Ext.create('Proxmox.button.Button', {
+            text: gettext('Remove'),
             disabled: true,
+            dangerous: true,
             selModel: sm,
             enableFn: (rec) =>
                 !!caps.vms['VM.Config.Network'] ||
                 !!caps.dc['Sys.Modify'] ||
                 !!caps.nodes['Sys.Modify'],
-            baseurl: me.base_url + '/',
-            callback: reload,
+            handler: function (btn, event, rec) {
+                Ext.create('PVE.window.FirewallObjectRemove', {
+                    item: { id: rec.data.name },
+                    url: me.base_url + '/' + rec.data.name,
+                    text: Ext.String.format(
+                        gettext("Are you sure you want to remove alias '{0}'"),
+                        rec.data.name,
+                    ),
+                    referenceActions: [
+                        {
+                            text: gettext('Keep'),
+                            value: 'keep',
+                            description: gettext(
+                                'Do not touch firewall rules and IPSet members referencing this alias.',
+                            ),
+                        },
+                        {
+                            text: gettext('Disable'),
+                            value: 'disable',
+                            description: gettext(
+                                'Disable firewall rules and delete IPSet members referencing this alias.',
+                            ),
+                        },
+                        {
+                            text: gettext('Delete'),
+                            value: 'drop',
+                            description: gettext(
+                                'Delete firewall rules and IPSet members referencing this alias.',
+                            ),
+                        },
+                    ],
+                    apiCallDone: reload,
+                }).show();
+            },
         });
 
         Ext.apply(me, {
-- 
2.47.3