all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v2 1/5] verify: drop useless try_block! in snapshot verification
Date: Tue, 10 Nov 2026 16:37:27 +0100	[thread overview]
Message-ID: <20261110153731.449671-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20261110153731.449671-1-c.ebner@proxmox.com>

Not needed and makes the code more concise as well as better readable
because of the reduced nesting level.

No functional changes.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/backup/verify.rs | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/src/backup/verify.rs b/src/backup/verify.rs
index 43bee6a36..18fb1ca4c 100644
--- a/src/backup/verify.rs
+++ b/src/backup/verify.rs
@@ -441,14 +441,12 @@ impl VerifyWorker {
 
         let mut verify_result = VerifyState::Ok;
         for info in manifest.files() {
-            let result = proxmox_lang::try_block!({
-                info!("  check {}", info.filename);
-                match info.filename.archive_type() {
-                    ArchiveType::FixedIndex => self.verify_fixed_index(backup_dir, info),
-                    ArchiveType::DynamicIndex => self.verify_dynamic_index(backup_dir, info),
-                    ArchiveType::Blob => Self::verify_blob(backup_dir, info),
-                }
-            });
+            info!("  check {}", info.filename);
+            let result = match info.filename.archive_type() {
+                ArchiveType::FixedIndex => self.verify_fixed_index(backup_dir, info),
+                ArchiveType::DynamicIndex => self.verify_dynamic_index(backup_dir, info),
+                ArchiveType::Blob => Self::verify_blob(backup_dir, info),
+            };
 
             self.worker.check_abort()?;
             self.worker.fail_on_shutdown()?;
-- 
2.47.3





  reply	other threads:[~2026-11-10 15:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 15:37 [PATCH proxmox-backup v2 0/5] fix #7606: verify: s3: handle transient fetch errors and add retry Christian Ebner
2026-11-10 15:37 ` Christian Ebner [this message]
2026-11-11  0:29   ` applied: [PATCH proxmox-backup v2 1/5] verify: drop useless try_block! in snapshot verification Thomas Lamprecht
2026-11-10 15:37 ` [PATCH proxmox-backup v2 2/5] datastore: snapshot: propagate errors in manifest update callback Christian Ebner
2026-11-10 15:37 ` [PATCH proxmox-backup v2 3/5] fix #7606: verify: s3: handle transient chunk load errors Christian Ebner
2026-11-10 15:37 ` [PATCH proxmox-backup v2 4/5] verify: s3: retry on transient response body collection errors Christian Ebner
2026-11-10 15:37 ` [PATCH proxmox-backup v2 5/5] verify: s3: early exit on chunk fetch or verification errors Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261110153731.449671-2-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal