[PATCH guest-common/manager/qemu-server v6 0/3] fix #5032: add guest time sync via QGA

[Jakob Klocker <j.klocker@proxmox.com>]

This series adds a new agent option 'sync-time-on-resume' to
automatically synchronize the guest clock via the QEMU Guest Agent
after operations that can leave the guest time stale. The option is
disabled by default and only takes effect when the QEMU Guest Agent is
enabled.

When a VM resumes with a restored RAM state (waking from hibernation or
rolling back to a snapshot that includes RAM), the guest clock
continues from the point the state was saved and no longer matches
wall-clock time. Skew also appears whenever the guest is briefly
frozen and resumed - after creating a snapshot, an
ordinary pause/resume, the resume step of a live migration, or a
vzdump in suspend mode.

When enabled, the option triggers a guest-set-time call:
 * after resuming from hibernation (suspend-to-disk)
 * after rolling back to a snapshot that includes RAM
 * after a live migration
 * after an ordinary pause/resume
 * after taking a snapshot
 * after a vzdump backup in suspend mode

The start, resume and rollback API endpoints also accept a
'sync-time-on-resume' parameter that overrides the configured value for
a single operation.

The option is exposed in the VM configuration GUI
so it can be toggled per guest.

Changes since v5:
 * drop the migration version check (covered by the strict config check
   series and the same-version cluster requirement)
 * vzdump: sync the guest clock after resuming from a suspend mode backup;
   snapshot mode doesn't pause the vCPUs and stop mode boots the guest
   fresh, so neither needs a sync
 * vm_resume: skip the sync when resuming from 'prelaunch' (e.g. a VM
   started paused for a backup) or after a reset, the guest boots fresh in
   both cases
 * guest_set_time: return whether the time was actually set
 * rebased on current master

Changes since v4:
 * rebased on current master
 * no functional changes

Link: https://bugzilla.proxmox.com/show_bug.cgi?id=5032


pve-guest-common:

Jakob Klocker (1):
  AbstractConfig: allow passing options to snapshot_rollback

 src/PVE/AbstractConfig.pm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


pve-manager:

Jakob Klocker (1):
  fix #5032: ui: qemu agent: add sync-time-on-resume option

 www/manager6/form/AgentFeatureSelector.js | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)


qemu-server:

Jakob Klocker (1):
  fix #5032: agent: sync guest time via QGA when the clock falls behind

 src/PVE/API2/Qemu.pm           | 75 ++++++++++++++++++++++++++++++++--
 src/PVE/CLI/qm.pm              |  2 +-
 src/PVE/QemuConfig.pm          | 12 +++++-
 src/PVE/QemuMigrate.pm         |  3 ++
 src/PVE/QemuServer.pm          | 18 +++++++-
 src/PVE/QemuServer/Agent.pm    | 64 +++++++++++++++++++++++++++++
 src/PVE/QemuServer/RunState.pm | 15 ++++++-
 src/PVE/VZDump/QemuServer.pm   | 25 +++++++++++-
 8 files changed, 203 insertions(+), 11 deletions(-)


Summary over all repositories:
  10 files changed, 224 insertions(+), 13 deletions(-)

-- 
Generated by murpp 0.12.0