From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id F2FEB1FF0EC for ; Sat, 07 Nov 2026 23:35:38 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 94DA5213F4; Sat, 07 Nov 2026 23:35:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794090928; x=1794695728; darn=lists.proxmox.com; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=bYD+NEibJziyOXjLUlPZLa3qS8f70qgQ/NFH3jhdnP4=; b=xiX1OzSRH3UFxED6LYkt/UXFvyMhFnmgNVZl6KGtC5biqrqgBAwD3cLh4iE4nj6cOy FfcvoIzh998pXGGCCWX2uHUNC8xHeoNDp/B1N3GURnT1CP04nY5yfUdLokxOARiEL77A u1F6L7WL84VTl6iESO7sbIuuYRwhW0kiRS/8m0EMgrKeilVJ4b7VCHXnHUQ9mOJQGCaK qwy2HgF+jyDRcoEtnVzkKI7iYbSlBYcZ6mQBcDMVSgBuKKn0VqLA02TCN0I93t3rfx7I r+Bn6d8nIc32zjKsxcDQJBwQV87D+NI5+Am1PQCbxKGqJWJQK6K9bSEkYAihrlOBwa5P rAlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794090928; x=1794695728; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=bYD+NEibJziyOXjLUlPZLa3qS8f70qgQ/NFH3jhdnP4=; b=i7FvNgwoh1rRgucnrQ7lVnQaSVBDHzOiHjc9/nvnNE2BOHsvtail78r1QImvFhgOnW A6XyP+sb3Ccdk+N1QKgLCAqJ6So015AGJB5HarQw/fizB7BMe6QDOnTZ7mKXNHWTPXDc zZTH+hVF1zS4Oe3wmbWR4ralQnUMuVFwRUyq2SOHuN659oxgLI5/IRM0QkskXAu3P5/K F/a3EoXJ9BAXbAiy4SQ5boXQAMw5tSZzbTD2FT0Rrc1Gl89//5Kcz/EgHebE5kwHSucd FYXjEGoj2QgpI1JwzwLaDvHUSiQk0MeLksdZEuN1zmdtMLkkPIM6amr+R6rj0Zw/gEvu U9WA== X-Gm-Message-State: APuU4Z+Im84sKbG01mw6TeTTNiPF8HRVWeh21PfdlE5xbL8xRdkFX3ww BA+UEid9CwraPSxP93SS3shmBBtozFAAfHdbse5xTPlV+ouqJ1Z4CvmMhtdNwNcQRRk= X-Gm-Gg: AYBFou0NTEBq3CgwQ5n97SJRWLjvuJ4lGga9jn7sy6Y9UkDF5vCq+j/lPOuOIxSA+34 +9H9eoNjN2EUjcoIfJnp+GgqJfCa0ay0OseTLx7rGNk5n4p5XbbSLHoAXcOXNFXJIXORW9o7SeR BMBrv5Lj+wx1oEZRdloYAeXRA2y6f+LOVYeLsCCbefXnKhy+ZV/8TxpI0P/FRKTBlKzjSpAXGPQ Jd34YTLy0Y2bczNdxWF/qoqkdMJl3yUm89myiulIU6FEh6srgb4tqhW/6EkyvuRv/1JMkpybok0 Y+AiR4FY2/nHLBF5HC2Svz7kgORgRWpOphdgc6xR81fN30Zicji0/ccxov3CvOeEkwvpNMVHyTk 8yohWtvOCap5bcvstF9aik2JzdgiQhOnP9Ry3iQq/Ey14CTdNDPLb0zvg91OoABI+HK0/wu2TXo AKUukvK48DC+SXEEAEfpjztFC+x4X5/4q32iR37gJFGMjFBUqa/0ZDXNenoeUD4cE/Ign4Oxaxx HLbI2Z8hWXjkWKon8DcC+tf7QxCg1E31g256Tew2XcYF2XdGUp6TuWXpYC0LwPHFuNEk0EtLGMq bO6o0yES2W9cgBs9T0x8KgIh+bmRMUJq/h5SAeHaCadR+3NKd6+rQPoD/7/F15Ubs9Zyydusqkq 8Tg0mpTUMqiJ0BG1yV2bNnxPuhux4WK1ZCwY+bVNOdfyMl8OemW8= X-Received: by 2002:a05:690e:118e:b0:66e:54a0:cdca with SMTP id 956f58d0204a3-67c3d9f9928mr87857d50.49.1794090927709; Sat, 07 Nov 2026 14:35:27 -0800 (PST) From: Lucas Barros To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox] fix #8127: notify: matcher: fix description of match-calendar Date: Sat, 7 Nov 2026 19:35:22 -0300 Message-ID: <20261107223522.23169-1-lucasbarros.kam@gmail.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.037 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: F7MPW5SW3GYCJ5E25YEWAKN2JB6PQRYD X-Message-ID-Hash: F7MPW5SW3GYCJ5E25YEWAKN2JB6PQRYD X-MailFrom: lucasbarros.kam@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The doc comment of the 'match-calendar' property was copied from 'match-severity', so the API schema, and with it the CLI help and the man page of 'proxmox-backup-manager notification matcher create' and 'update', describes it as a list of matched severity levels. The option matches the timestamp of a notification against calendar entries, though. Use a description that fits what the option does. Signed-off-by: Lucas Barros --- The 'match-severity' doc comment right above it is correct and left as is. The items description of the same property in the api macro ("Time stamps to match") is left alone as well. Doc comment change only. I did not build the crate locally (no Rust toolchain on this machine). This patch was prepared with the help of an LLM based coding assistant; I reviewed the change and ran the tests mentioned above myself. proxmox-notify/src/matcher/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proxmox-notify/src/matcher/mod.rs b/proxmox-notify/src/matcher/mod.rs index 59be88f..af87a4e 100644 --- a/proxmox-notify/src/matcher/mod.rs +++ b/proxmox-notify/src/matcher/mod.rs @@ -93,7 +93,7 @@ pub struct MatcherConfig { #[cfg(feature = "legacy-matchers")] pub match_severity: Vec, - /// List of matched severity levels. + /// List of matched calendar entries. #[serde(default, skip_serializing_if = "Vec::is_empty")] #[updater(serde(skip_serializing_if = "Option::is_none"))] #[cfg(feature = "legacy-matchers")] -- 2.50.1 (Apple Git-155)