From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C69F11FF0AF for ; Fri, 06 Nov 2026 18:22:55 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7A5B7212FB; Fri, 06 Nov 2026 18:22:55 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-widget-toolkit v2 01/43] form: date time field: init with now instead of epoch on empty fields Date: Fri, 6 Nov 2026 18:21:53 +0100 Message-ID: <20261106172235.890542-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261106172235.890542-1-c.ebner@proxmox.com> References: <20261106172235.890542-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793985772248 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.491 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2C4R72GTRTVHWXKOMDL3X5GDZU7643FO X-Message-ID-Hash: 2C4R72GTRTVHWXKOMDL3X5GDZU7643FO X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When no value was set yet, the date and time parts were merged into a date with Unix epoch as base. When selecting a time, this resulted in a date in 1970 and when picking a date, the time was based on the current time for Unix epoch in local timezone. For improved usability and convenience, default to midnight in local time if a date was picked and today when picking a time. Signed-off-by: Christian Ebner --- src/form/DateTimeField.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/form/DateTimeField.js b/src/form/DateTimeField.js index e9f60e3..c871bbc 100644 --- a/src/form/DateTimeField.js +++ b/src/form/DateTimeField.js @@ -23,7 +23,7 @@ Ext.define('Proxmox.DateTimeField', { this.set('datetime', null); return; } - let datetime = new Date(this.get('datetime')); + let datetime = new Date(this.get('datetime') ?? date); datetime.setFullYear(date.getFullYear(), date.getMonth(), date.getDate()); this.set('datetime', datetime); }, @@ -38,7 +38,7 @@ Ext.define('Proxmox.DateTimeField', { this.set('datetime', null); return; } - let datetime = new Date(this.get('datetime')); + let datetime = new Date(this.get('datetime') ?? Date.now()); datetime.setHours(time.getHours()); datetime.setMinutes(time.getMinutes()); datetime.setSeconds(time.getSeconds()); -- 2.47.3