From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 372481FF0AF for ; Fri, 06 Nov 2026 18:23:30 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7427C21707; Fri, 06 Nov 2026 18:23:09 +0100 (CET) From: Christian Ebner To: pbs-devel@lists.proxmox.com Subject: [PATCH proxmox-backup v2 15/43] server: allow iterating contents for Datastore.Append permissions Date: Fri, 6 Nov 2026 18:22:07 +0100 Message-ID: <20261106172235.890542-16-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261106172235.890542-1-c.ebner@proxmox.com> References: <20261106172235.890542-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793985775462 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.474 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 572UQPVVHZRR22PGO5MOKFV77IRNZ5CB X-Message-ID-Hash: 572UQPVVHZRR22PGO5MOKFV77IRNZ5CB X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Appending backups to groups in namespaces must be aware of pre-existing contents, so it must be allowed to iterate those. Further, sort the privs list alphabetically to improve readability. Signed-off-by: Christian Ebner --- src/backup/hierarchy.rs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/backup/hierarchy.rs b/src/backup/hierarchy.rs index ef8efd323..d81dc3565 100644 --- a/src/backup/hierarchy.rs +++ b/src/backup/hierarchy.rs @@ -3,8 +3,8 @@ use std::sync::Arc; use anyhow::{Error, bail}; use pbs_api_types::{ - Authid, BackupNamespace, PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_BACKUP, PRIV_DATASTORE_MODIFY, - PRIV_DATASTORE_READ, privs_to_priv_names, + Authid, BackupNamespace, PRIV_DATASTORE_APPEND, PRIV_DATASTORE_AUDIT, PRIV_DATASTORE_BACKUP, + PRIV_DATASTORE_MODIFY, PRIV_DATASTORE_READ, privs_to_priv_names, }; use pbs_config::CachedUserInfo; use pbs_datastore::{DataStore, ListGroups, ListNamespacesRecursive, backup_info::BackupGroup}; @@ -151,8 +151,11 @@ impl<'a> ListAccessibleBackupGroups<'a> { } } -pub static NS_PRIVS_OK: u64 = - PRIV_DATASTORE_MODIFY | PRIV_DATASTORE_READ | PRIV_DATASTORE_BACKUP | PRIV_DATASTORE_AUDIT; +pub static NS_PRIVS_OK: u64 = PRIV_DATASTORE_APPEND + | PRIV_DATASTORE_AUDIT + | PRIV_DATASTORE_BACKUP + | PRIV_DATASTORE_READ + | PRIV_DATASTORE_MODIFY; impl Iterator for ListAccessibleBackupGroups<'_> { type Item = Result; -- 2.47.3