From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id A6F1A1FF0AF for ; Fri, 06 Nov 2026 01:54:08 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C9DA32166F; Fri, 06 Nov 2026 01:51:08 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v3 manager 45/76] api: ceph: osd: keep iSCSI LUNs out of OSD creation Date: Fri, 6 Nov 2026 00:31:20 +0100 Message-ID: <20261105233336.2178064-46-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261105233336.2178064-1-t.lamprecht@proxmox.com> References: <20261105233336.2178064-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793926180527 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.319 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: Q6A5IZXTRTNJBZ2SUREUX7PX25336UOU X-Message-ID-Hash: Q6A5IZXTRTNJBZ2SUREUX7PX25336UOU X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Disk enumeration now includes iSCSI LUNs, which other nodes may use. Reject them for OSD, DB, and WAL devices, matching the other local disk operations. Check again in the worker, as a device name can belong to another device by the time it runs. Signed-off-by: Thomas Lamprecht --- PVE/API2/Ceph/OSD.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PVE/API2/Ceph/OSD.pm b/PVE/API2/Ceph/OSD.pm index 442b99292..af0fdf069 100644 --- a/PVE/API2/Ceph/OSD.pm +++ b/PVE/API2/Ceph/OSD.pm @@ -379,6 +379,9 @@ __PACKAGE__->register_method({ my $test_disk_requirements = sub { my ($disklist) = @_; + # refuse shared SAN devices such as iSCSI LUNs, which get_disks lists as well + PVE::Diskmanage::assert_local_device($_->{dev}, $disklist) for values %$devs; + my $dev = $devs->{dev}->{dev}; my $devname = $devs->{dev}->{name}; die "unable to get device info for '$dev'\n" if !$disklist->{$devname}; -- 2.47.3