[PATCH manager 1/4] ui: form: list field: don't modify the class definition

[Dominik Csapak <d.csapak@proxmox.com>]

Modifying a property defined on the class level modifies the prototype
of that class. This can have unintended consequences when only part of
the config is used in some widgets.

This can be seen here with the `Registered Tags` and `User Tag Access`
lists: One has no emptytext while the other does. Opening them in an
alternating fashion adds the empty text from one to the other.

Fix it by constructing the initial items list in initComponent, and let
the widget modify that instead.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 www/manager6/form/ListField.js | 46 +++++++++++++++++-----------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/www/manager6/form/ListField.js b/www/manager6/form/ListField.js
index 49651bc5..6fcbdfd8 100644
--- a/www/manager6/form/ListField.js
+++ b/www/manager6/form/ListField.js
@@ -124,34 +124,34 @@ Ext.define('PVE.form.ListField', {
         },
     },
 
-    items: [
-        {
-            xtype: 'grid',
-            reference: 'grid',
+    initComponent: function () {
+        let me = this;
 
-            viewConfig: {
-                deferEmptyText: false,
-            },
+        me.items = [
+            {
+                xtype: 'grid',
+                reference: 'grid',
 
-            store: {
-                listeners: {
-                    update: function () {
-                        this.commitChanges();
+                viewConfig: {
+                    deferEmptyText: false,
+                },
+
+                store: {
+                    listeners: {
+                        update: function () {
+                            this.commitChanges();
+                        },
                     },
                 },
             },
-        },
-        {
-            xtype: 'button',
-            text: gettext('Add'),
-            iconCls: 'fa fa-plus-circle',
-            handler: 'addLine',
-            margin: '5 0 0 0',
-        },
-    ],
-
-    initComponent: function () {
-        let me = this;
+            {
+                xtype: 'button',
+                text: gettext('Add'),
+                iconCls: 'fa fa-plus-circle',
+                handler: 'addLine',
+                margin: '5 0 0 0',
+            },
+        ];
 
         for (const [key, value] of Object.entries(me.gridConfig ?? {})) {
             me.items[0][key] = value;
-- 
2.47.3