From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 259221FF0DF for ; Thu, 05 Nov 2026 11:37:48 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9FE0A215AE; Thu, 05 Nov 2026 11:37:43 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH-SERIES storage v2 0/2] api: prune backups: improve permission checks Date: Thu, 5 Nov 2026 11:35:42 +0100 Message-ID: <20261105103736.52417-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793875059706 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.297 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DR3WNFBI2NNMW7MGELIB3KZJSUOAP4OY X-Message-ID-Hash: DR3WNFBI2NNMW7MGELIB3KZJSUOAP4OY X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Changes in v2: * Different approach. Do not use check_volume_access() for filtering. Aligning the permissions between the dry run and active run is more natural here. Align the permission checks for dry run and active run, since that is natural here. And remove an unnatural restriction for the case where an explicit guest ID is specified. pve-storage: Fiona Ebner (2): api: prune backups: align permission check for dry run and active run api: prune backups: allow Datastore.Allocate even without VM.Backup src/PVE/API2/Storage/PruneBackups.pm | 37 +++++++++++++++++++--------- 1 file changed, 25 insertions(+), 12 deletions(-) Summary over all repositories: 1 files changed, 25 insertions(+), 12 deletions(-) -- Generated by git-murpp 0.5.0