From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id B62571FF0DF for ; Thu, 05 Nov 2026 11:03:51 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A59A4214DF; Thu, 05 Nov 2026 11:03:48 +0100 (CET) From: Kefu Chai To: pve-devel@lists.proxmox.com Subject: [PATCH manager] fix #8281: ceph: unify add-storage parameter Date: Thu, 5 Nov 2026 18:03:41 +0800 Message-ID: <20261105100341.3100419-1-k.chai@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793873024351 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.249 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: P55AHF6W5C6GEB6PTMDBSFXAXFL7QHXR X-Message-ID-Hash: P55AHF6W5C6GEB6PTMDBSFXAXFL7QHXR X-MailFrom: k.chai@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Pool and CephFS creation both configure a PVE storage entry, but use different option names. Use add-storage consistently to make the CLI less confusing and easier to script, while keeping add_storages as a deprecated alias for existing callers. Signed-off-by: Kefu Chai --- PVE/API2/Ceph/FS.pm | 2 +- PVE/API2/Ceph/Pool.pm | 14 ++++++++++---- www/manager6/ceph/Pool.js | 2 +- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/PVE/API2/Ceph/FS.pm b/PVE/API2/Ceph/FS.pm index 8f2e8b63..e738552e 100644 --- a/PVE/API2/Ceph/FS.pm +++ b/PVE/API2/Ceph/FS.pm @@ -138,7 +138,7 @@ __PACKAGE__->register_method({ maximum => 32768, }, 'add-storage' => { - description => "Configure the created CephFS as storage for this cluster.", + description => "Add the created CephFS to the cluster storage configuration.", type => 'boolean', optional => 1, default => 0, diff --git a/PVE/API2/Ceph/Pool.pm b/PVE/API2/Ceph/Pool.pm index 8fd11b82..c03a4799 100644 --- a/PVE/API2/Ceph/Pool.pm +++ b/PVE/API2/Ceph/Pool.pm @@ -438,14 +438,20 @@ __PACKAGE__->register_method({ additionalProperties => 0, properties => { node => get_standard_option('pve-node'), - add_storages => { - description => "Configure VM and CT storage using the new pool. Defaults to" - . " false for replicated pools and to true for erasure-coded pools" + 'add-storage' => { + description => "Add the created Ceph pool to the cluster storage configuration." + . " Defaults to false for replicated pools and to true for erasure-coded pools" . " (since EC pools are typically only useful when wired up to storage).", type => 'boolean', optional => 1, default => 0, }, + add_storages => { + description => "Deprecated alias for 'add-storage'.", + alias => 'add-storage', + type => 'boolean', + optional => 1, + }, 'erasure-coding' => { description => "Create an erasure coded pool for RBD with an accompaning" . " replicated pool for metadata storage. With EC, the common ceph options 'size'," @@ -466,7 +472,7 @@ __PACKAGE__->register_method({ my $pool = my $name = extract_param($param, 'name'); my $node = extract_param($param, 'node'); - my $add_storages = extract_param($param, 'add_storages'); + my $add_storages = extract_param($param, 'add-storage'); my $rpcenv = PVE::RPCEnvironment::get(); my $user = $rpcenv->get_user(); diff --git a/www/manager6/ceph/Pool.js b/www/manager6/ceph/Pool.js index a64230fb..39dcd5da 100644 --- a/www/manager6/ceph/Pool.js +++ b/www/manager6/ceph/Pool.js @@ -109,7 +109,7 @@ Ext.define('PVE.CephPoolInputPanel', { value: '{isCreate}', hidden: '{!isCreate}', }, - name: 'add_storages', + name: 'add-storage', labelWidth: 140, autoEl: { tag: 'div', -- 2.47.3