From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id CC1C21FF0DF for ; Thu, 05 Nov 2026 09:25:35 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E3D9921609; Thu, 05 Nov 2026 09:25:28 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v7 0/2] hotplug: improve and fix cleanup/error handling Date: Thu, 5 Nov 2026 09:22:13 +0100 Message-ID: <20261105082524.428152-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.323 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RENSLMAEIQE4EXWOU765SUQMWBPDAFYV X-Message-ID-Hash: RENSLMAEIQE4EXWOU765SUQMWBPDAFYV X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This replaces my earlier v4 9/9 patch[0] It uses a different approach now by unifying the cleanup and removal of disks and their controllers. changes from v6: * call print_drivedevice_full before adding the SCSI controller, so a volume rejected by the storage layer (e.g. a vanished storage) does not cause a controller plug/unplug cycle, and add a test for it * add a test for a failed disk hotplug on a shared SCSI controller, which must keep the controller for the remaining disks changes from v5: * rebase on master * rename helper to 'delete_disk_hardware' * don't eval the individual calls, but always the whole function (drops noerr parameter) changes from v4: * rebase on master * new bugfix (1/4) * new patch for iothread deletion * new patch for refactoring the cleanup 0: https://lore.proxmox.com/pve-devel/20261023130324.451252-10-d.csapak@proxmox.com/ Dominik Csapak (2): hotplug: factor out cleanup of disk devices hotplug: clean up disk devices/objects if adding them failed src/PVE/QemuServer.pm | 75 ++++++++++++------- src/test/hotplug/disk-add-fail.conf | 19 +++++ src/test/hotplug/disk-add-fail.conf.expected | 10 +++ src/test/hotplug/disk-add-fail2.conf | 17 +++++ src/test/hotplug/disk-add-fail2.conf.expected | 1 + .../disk-add-scsi-shared-controller-fail.conf | 19 +++++ ...-scsi-shared-controller-fail.conf.expected | 8 ++ .../disk-add-scsi-single-disk-fail.conf | 19 +++++ ...sk-add-scsi-single-disk-fail.conf.expected | 12 +++ .../hotplug/disk-add-scsi-single-fail.conf | 19 +++++ .../disk-add-scsi-single-fail.conf.expected | 5 ++ 11 files changed, 175 insertions(+), 29 deletions(-) create mode 100644 src/test/hotplug/disk-add-fail.conf create mode 100644 src/test/hotplug/disk-add-fail.conf.expected create mode 100644 src/test/hotplug/disk-add-fail2.conf create mode 100644 src/test/hotplug/disk-add-fail2.conf.expected create mode 100644 src/test/hotplug/disk-add-scsi-shared-controller-fail.conf create mode 100644 src/test/hotplug/disk-add-scsi-shared-controller-fail.conf.expected create mode 100644 src/test/hotplug/disk-add-scsi-single-disk-fail.conf create mode 100644 src/test/hotplug/disk-add-scsi-single-disk-fail.conf.expected create mode 100644 src/test/hotplug/disk-add-scsi-single-fail.conf create mode 100644 src/test/hotplug/disk-add-scsi-single-fail.conf.expected -- 2.47.3