From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id CE9661FF0C0
	for <inbox@lore.proxmox.com>; Wed, 04 Nov 2026 20:05:35 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id C9B7A215AE;
	Wed, 04 Nov 2026 20:04:22 +0100 (CET)
From: =?UTF-8?q?Michael=20K=C3=B6ppl?= <m.koeppl@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH e2e-tests 13/38] scripts: retry container template download,
 fail if it fails
Date: Wed,  4 Nov 2026 20:03:20 +0100
Message-ID: <20261104190345.2573464-14-m.koeppl@proxmox.com>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20261104190345.2573464-1-m.koeppl@proxmox.com>
References: <20261104190345.2573464-1-m.koeppl@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793819034440
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.218 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: EGDPJSTNLOSYVJVRFKEC3C3N46FVUA3N
X-Message-ID-Hash: EGDPJSTNLOSYVJVRFKEC3C3N46FVUA3N
X-MailFrom: m.koeppl@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Since the download can sometimes be rejected with a 503, retry it after
a while instead of failing silently. Also, do not fail silently if the
download is unsuccessful even with multiple attempts. The setup then
would not work anyway.

Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
---
 scripts/download-container-image.sh | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/scripts/download-container-image.sh b/scripts/download-container-image.sh
index b14a636..5db8af8 100755
--- a/scripts/download-container-image.sh
+++ b/scripts/download-container-image.sh
@@ -9,5 +9,14 @@ IMAGE=$2
 ssh -i $SSH_KEY $USER@$HOST -o StrictHostKeyChecking=no <<EOF
 set -e
 
-pveam download $STORAGE $IMAGE
+path=\$(pvesm path $STORAGE:vztmpl/$IMAGE)
+# Sometimes requests are rejected with 503, to try again after a while.
+for attempt in 1 2 3 4 5; do
+    pveam download $STORAGE $IMAGE || true
+    # Explicitly check for the path, since download will still return 0 if it fails.
+    [ -e "\$path" ] && exit 0
+    sleep \$((attempt * 10))
+done
+echo "downloading $IMAGE to $STORAGE failed" >&2
+exit 1
 EOF
-- 
2.47.3