From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 8C7B41FF0C0 for ; Wed, 04 Nov 2026 20:05:43 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8CBC1215CA; Wed, 04 Nov 2026 20:04:25 +0100 (CET) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH e2e-tests 12/38] lib: add helpers to use a PBS datastore as PVE storage Date: Wed, 4 Nov 2026 20:03:19 +0100 Message-ID: <20261104190345.2573464-13-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261104190345.2573464-1-m.koeppl@proxmox.com> References: <20261104190345.2573464-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793819034341 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.217 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LRY7HPDS4IYG3Q62ZZCTIXRR5UYITNHM X-Message-ID-Hash: LRY7HPDS4IYG3Q62ZZCTIXRR5UYITNHM X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Tests that back up guests to PBS first create a datastore on PBS and add it to PVE as a storage, and remove both again afterwards. Add helpers for creating and removing the datastore and for adding it as a storage, so these tests do not have to repeat the same API calls. Signed-off-by: Michael Köppl --- Proxmox/Test/PBSInstance.pm | 19 +++++++++++++++++++ Proxmox/Test/PVEInstance.pm | 19 +++++++++++++++++++ 2 files changed, 38 insertions(+) diff --git a/Proxmox/Test/PBSInstance.pm b/Proxmox/Test/PBSInstance.pm index 80138e3..165e4bc 100644 --- a/Proxmox/Test/PBSInstance.pm +++ b/Proxmox/Test/PBSInstance.pm @@ -10,4 +10,23 @@ sub new { return $class->SUPER::new($name, $config, 8007, 'PBSAuthCookie'); } +# Create a datastore named $name in /mnt/$name and assert that the creation task succeeded. Dies if +# it failed. +sub create_datastore { + my ($self, $name) = @_; + + my $upid = $self->client()->post('/config/datastore', { name => $name, path => "/mnt/$name" }); + $self->task_ok($upid, "created datastore '$name' on PBS") + or die "creating datastore '$name' failed\n"; +} + +# Remove a datastore created by create_datastore() together with its contents. +sub remove_datastore { + my ($self, $name) = @_; + + my $upid = $self->client()->delete("/config/datastore/$name", { 'destroy-data' => 1 }); + $self->wait_for_task($upid); + $self->run_command("rm -rf /mnt/$name"); +} + 1; diff --git a/Proxmox/Test/PVEInstance.pm b/Proxmox/Test/PVEInstance.pm index d55aa4a..e95480d 100644 --- a/Proxmox/Test/PVEInstance.pm +++ b/Proxmox/Test/PVEInstance.pm @@ -123,6 +123,25 @@ sub wait_for_qemu_cleanup { ); } +# Add the datastore $datastore of the PBS instance $pbs as storage $storage_id for backups. +sub add_pbs_storage { + my ($self, $storage_id, $pbs, $datastore) = @_; + + $self->client()->post( + '/storage', + { + storage => $storage_id, + type => 'pbs', + server => $pbs->get_ip(), + datastore => $datastore, + username => 'root@pam', + password => $pbs->get_root_password(), + fingerprint => $pbs->get_fingerprint(), + content => 'backup', + }, + ); +} + sub destroy_guest { my ($self, $type, $vmid) = @_; return $self->destroy_guest_on($self->get_nodename(), $type, $vmid); -- 2.47.3