[PATCH proxmox-backup v5 4/9] ui: prune job: align prune edit window to other "Enable" checkboxes

[Jonas Theisen <j.theisen@proxmox.com>]

Align the already existing "Enabled" checkbox in the prune job edit
window to the "Enable" checkboxes of the other job types: rename it
to "Enable", as is more common throughout the UI, add the same
tooltip, and disable the schedule field while the checkbox is
unchecked.

Signed-off-by: Jonas Theisen <j.theisen@proxmox.com>
---
 www/Utils.js               | 15 +++++++++++++
 www/window/PruneJobEdit.js | 44 ++++++++++++++++++++++++++------------
 2 files changed, 45 insertions(+), 14 deletions(-)

diff --git a/www/Utils.js b/www/Utils.js
index d6bfd459e..f4a27c13b 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -127,6 +127,21 @@ Ext.define('PBS.Utils', {
         }
     },
 
+    // jobs are disabled via a 'disable' flag in the API, but the UI shows an "Enable" checkbox
+    enableToDisable: function (values, prefix = '') {
+        values[`${prefix}disable`] = !values[`${prefix}enable`];
+        delete values[`${prefix}enable`];
+
+        return values;
+    },
+
+    disableToEnable: function (values, prefix = '') {
+        values[`${prefix}enable`] = !values[`${prefix}disable`];
+        delete values[`${prefix}disable`];
+
+        return values;
+    },
+
     render_datetime_utc: function (datetime) {
         let pad = (number) => (number < 10 ? '0' + number : number);
         return (
diff --git a/www/window/PruneJobEdit.js b/www/window/PruneJobEdit.js
index a3dafde21..9f6c972ec 100644
--- a/www/window/PruneJobEdit.js
+++ b/www/window/PruneJobEdit.js
@@ -43,6 +43,21 @@ Ext.define('PBS.window.PruneJobEdit', {
         },
     },
 
+    viewModel: {
+        data: {
+            jobEnabled: true,
+        },
+    },
+
+    setValues: function (values) {
+        let me = this;
+
+        if (!values.schedule) {
+            values.disable = true;
+        }
+        me.callParent([values]);
+    },
+
     items: {
         xtype: 'inputpanel',
         onGetValues: function (values) {
@@ -51,18 +66,10 @@ Ext.define('PBS.window.PruneJobEdit', {
             if (!values.id && me.up('pbsPruneJobEdit').isCreate) {
                 values.id = 's-' + Ext.data.identifier.Uuid.Global.generate().slice(0, 13);
             }
-            values.disable = !values.enable;
-            delete values.enable;
-
-            return values;
-        },
-        onSetValues: function (values) {
-            let _me = this;
-            values.enable = !values.disable;
-            delete values.disable;
 
-            return values;
+            return PBS.Utils.enableToDisable(values);
         },
+        onSetValues: (values) => PBS.Utils.disableToEnable(values),
         column1: [
             {
                 xtype: 'pmxDisplayEditField',
@@ -115,14 +122,23 @@ Ext.define('PBS.window.PruneJobEdit', {
                 cbind: {
                     value: '{scheduleValue}',
                 },
+                bind: {
+                    disabled: '{!jobEnabled}',
+                },
             },
             {
                 xtype: 'proxmoxcheckbox',
-                fieldLabel: gettext('Enabled'),
+                fieldLabel: gettext('Enable'),
                 name: 'enable',
-                uncheckedValue: 0,
-                defaultValue: 1,
-                checked: true,
+                autoEl: {
+                    tag: 'div',
+                    'data-qtip': gettext('Enable scheduled execution of this job.'),
+                },
+                bind: {
+                    value: '{jobEnabled}',
+                },
+                uncheckedValue: false,
+                value: true, // value needs to be set despite bind for setValues to work
             },
         ],
 
-- 
2.47.3