all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH firewall 0/3] fix #1965: cache the cluster firewall config
Date: Wed,  4 Nov 2026 15:19:28 +0100	[thread overview]
Message-ID: <20261104141931.399659-1-a.bied-charreton@proxmox.com> (raw)

The cluster firewall config is is not currently cached, so it is re-
parsed on every load. This can use a noticeable amount of CPU if the
firewall configuration contains large ipsets, for example.

These changes are based on an old series by Stefan Hrdlicka [0]. The
only major diff compared to that series is that the in-memory firewall
config now includes SDN ipsets. Those are not stored in cluster.fw, so
changes to those do not create new versions for it and therefore need to
be handled separately, see commit messages for details.

[0] https://lists.proxmox.com/pipermail/pve-devel/2022-November/055051.html


pve-firewall:

Arthur Bied-Charreton (3):
  firewall: run make tidy
  firewall: parser: factor out error logging
  fix #1965: firewall: cache cluster config

 src/PVE/API2/Firewall/Helpers.pm |   3 +-
 src/PVE/Firewall.pm              | 124 ++++++++++++++++++++++---------
 2 files changed, 89 insertions(+), 38 deletions(-)


Summary over all repositories:
  2 files changed, 89 insertions(+), 38 deletions(-)

-- 
Generated by murpp 0.12.1




             reply	other threads:[~2026-11-04 14:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04 14:19 Arthur Bied-Charreton [this message]
2026-11-04 14:19 ` [PATCH pve-firewall 1/3] firewall: run make tidy Arthur Bied-Charreton
2026-11-04 14:19 ` [PATCH pve-firewall 2/3] firewall: parser: factor out error logging Arthur Bied-Charreton
2026-11-04 14:19 ` [PATCH pve-firewall 3/3] fix #1965: firewall: cache cluster config Arthur Bied-Charreton
2026-11-04 16:15   ` Stefan Hanreich
2026-11-05  8:19     ` Arthur Bied-Charreton
2026-11-04 16:36   ` Stefan Hanreich
2026-11-05  8:15     ` Arthur Bied-Charreton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261104141931.399659-1-a.bied-charreton@proxmox.com \
    --to=a.bied-charreton@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal