From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id CAE831FF0AA for ; Tue, 03 Nov 2026 13:48:50 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E238D218A2; Tue, 03 Nov 2026 13:48:41 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH cluster v6 02/26] cluster: add more convenience helpers for checking node versions Date: Tue, 3 Nov 2026 13:47:54 +0100 Message-ID: <20261103124831.139399-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261103124831.139399-1-f.ebner@proxmox.com> References: <20261103124831.139399-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793710116154 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.318 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PNHNMOX43LUATSBJGJ5LYVVGPBNMOY5F X-Message-ID-Hash: PNHNMOX43LUATSBJGJ5LYVVGPBNMOY5F X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Move the get_node_pvecfg_version() from qemu-server, so it can be used by other modules and add a node_pvecfg_version_at_least() function for convenience. In preparation to check the node version for container migration and from HA manager too. Signed-off-by: Fiona Ebner --- Changes in v6: * Adapt to David's patch that moved pvecfg_min_version() to Tools module. src/PVE/Cluster.pm | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/PVE/Cluster.pm b/src/PVE/Cluster.pm index 1661a26..10c5686 100644 --- a/src/PVE/Cluster.pm +++ b/src/PVE/Cluster.pm @@ -973,4 +973,21 @@ sub assert_min_cluster_version { return 1; } +sub get_node_pvecfg_version { + my ($node) = @_; + + my $nodes_version_info = get_node_kv('version-info', $node); + return if !$nodes_version_info->{$node}; + + my $version_info = decode_json($nodes_version_info->{$node}); + return $version_info->{version}; +} + +sub node_pvecfg_version_at_least { + my ($node, $major, $minor, $release) = @_; + + my $version = get_node_pvecfg_version($node); + return $version && pvecfg_min_version($version, $major, $minor, $release); +} + 1; -- 2.47.3