From: Robert Obkircher <r.obkircher@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH v1 proxmox-backup 6/8] tree-wide: remove redundant ref keyword in pattern matches
Date: Tue, 3 Nov 2026 12:28:42 +0100 [thread overview]
Message-ID: <20261103113054.184327-7-r.obkircher@proxmox.com> (raw)
In-Reply-To: <20261103113054.184327-1-r.obkircher@proxmox.com>
These are no longer necessary and do not compile in the 2024 edition.
Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
---
pbs-client/src/catalog_shell.rs | 2 +-
| 2 +-
src/api2/config/sync.rs | 2 +-
src/tape/inventory.rs | 10 ++++------
src/tape/media_pool.rs | 2 +-
src/tape/media_set.rs | 2 +-
6 files changed, 9 insertions(+), 11 deletions(-)
diff --git a/pbs-client/src/catalog_shell.rs b/pbs-client/src/catalog_shell.rs
index 3a923648b..e74725af8 100644
--- a/pbs-client/src/catalog_shell.rs
+++ b/pbs-client/src/catalog_shell.rs
@@ -488,7 +488,7 @@ impl Shell {
accessor: &Accessor,
follow_symlinks: &mut Option<usize>,
) -> Result<(), Error> {
- if let Some(ref mut symlink_count) = follow_symlinks {
+ if let Some(symlink_count) = follow_symlinks {
*symlink_count += 1;
if *symlink_count > MAX_SYMLINK_COUNT {
bail!("too many levels of symbolic links");
--git a/pbs-client/src/pxar/extract.rs b/pbs-client/src/pxar/extract.rs
index 2ef3657a6..a1d4eb7c2 100644
--- a/pbs-client/src/pxar/extract.rs
+++ b/pbs-client/src/pxar/extract.rs
@@ -147,7 +147,7 @@ where
let mut prelude_file = open_options
.open(path)
.with_context(|| format!("error creating prelude file '{path:?}'"))?;
- if let pxar::EntryKind::Prelude(ref prelude) = entry.kind() {
+ if let pxar::EntryKind::Prelude(prelude) = entry.kind() {
prelude_file.write_all(prelude.as_ref())?;
} else {
info!("unexpected entry kind for prelude");
diff --git a/src/api2/config/sync.rs b/src/api2/config/sync.rs
index beed6e7e3..4d1a19c9e 100644
--- a/src/api2/config/sync.rs
+++ b/src/api2/config/sync.rs
@@ -362,7 +362,7 @@ fn keep_previous_key_as_associated(
) {
if let Some(prev) = current_active {
match associated_keys {
- Some(ref mut keys) => {
+ Some(keys) => {
if !keys.contains(prev) {
keys.push(prev.clone());
}
diff --git a/src/tape/inventory.rs b/src/tape/inventory.rs
index 12cca02c6..1ce4570d2 100644
--- a/src/tape/inventory.rs
+++ b/src/tape/inventory.rs
@@ -532,12 +532,10 @@ impl Inventory {
return i64::MAX;
}
MediaSetPolicy::AlwaysCreate => set_start_time,
- MediaSetPolicy::CreateAt(ref event) => {
- match event.compute_next_event(set_start_time) {
- Ok(Some(next)) => next,
- Ok(None) | Err(_) => return i64::MAX,
- }
- }
+ MediaSetPolicy::CreateAt(event) => match event.compute_next_event(set_start_time) {
+ Ok(Some(next)) => next,
+ Ok(None) | Err(_) => return i64::MAX,
+ },
},
};
diff --git a/src/tape/media_pool.rs b/src/tape/media_pool.rs
index 0cad7ab7d..fdd613d2c 100644
--- a/src/tape/media_pool.rs
+++ b/src/tape/media_pool.rs
@@ -325,7 +325,7 @@ impl MediaPool {
let mut list = Vec::new();
for opt_uuid in self.current_media_set.media_list().iter() {
match opt_uuid {
- Some(ref uuid) => list.push(uuid),
+ Some(uuid) => list.push(uuid),
None => bail!("current_media_list failed - media set is incomplete"),
}
}
diff --git a/src/tape/media_set.rs b/src/tape/media_set.rs
index 147fb643b..29de98e9e 100644
--- a/src/tape/media_set.rs
+++ b/src/tape/media_set.rs
@@ -59,7 +59,7 @@ impl MediaSet {
match self.media_list.last() {
None => None,
Some(None) => None,
- Some(Some(ref last_uuid)) => Some(last_uuid),
+ Some(Some(last_uuid)) => Some(last_uuid),
}
}
--
2.47.3
next prev parent reply other threads:[~2026-11-03 11:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 11:28 [PATCH v1 proxmox-backup 0/8] fix warnings and rust edition incompatibilities Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 1/8] tree-wide: fix clippy::useless_borrows_in_formatting Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 2/8] tape: fix clippy::question_mark Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 3/8] api: fix clippy::unnecessary_lazy_evaluations Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 4/8] cargo: update minimum rust version to 1.91 Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 5/8] tree-wide: mark extern blocks as unsafe and add some safety comments Robert Obkircher
2026-11-03 11:28 ` Robert Obkircher [this message]
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 7/8] tree-wide: add empty use<> bounds to return position impl traits Robert Obkircher
2026-11-03 11:28 ` [PATCH v1 proxmox-backup 8/8] cargo: remove unused dependencies Robert Obkircher
2026-11-05 11:07 ` applied-series: [PATCH v1 proxmox-backup 0/8] fix warnings and rust edition incompatibilities Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261103113054.184327-7-r.obkircher@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.