From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E7A811FF0AA for ; Tue, 03 Nov 2026 12:31:34 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A672821861; Tue, 03 Nov 2026 12:31:34 +0100 (CET) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 proxmox-backup 1/8] tree-wide: fix clippy::useless_borrows_in_formatting Date: Tue, 3 Nov 2026 12:28:37 +0100 Message-ID: <20261103113054.184327-2-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261103113054.184327-1-r.obkircher@proxmox.com> References: <20261103113054.184327-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793705490832 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.511 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: FKJYPIESMF2J2ZRRRWIVKWZHCGMTSKE7 X-Message-ID-Hash: FKJYPIESMF2J2ZRRRWIVKWZHCGMTSKE7 X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: cargo clippy --fix -- -A clippy::all -D clippy::useless_borrows_in_formatting Signed-off-by: Robert Obkircher --- src/api2/access/mod.rs | 2 +- src/api2/admin/datastore.rs | 4 ++-- src/api2/config/datastore.rs | 2 +- src/api2/node/disks/directory.rs | 2 +- src/api2/node/disks/zfs.rs | 2 +- src/api2/node/services.rs | 2 +- src/server/verify_job.rs | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/api2/access/mod.rs b/src/api2/access/mod.rs index 2b38806c0..b6ea58317 100644 --- a/src/api2/access/mod.rs +++ b/src/api2/access/mod.rs @@ -207,7 +207,7 @@ pub fn list_permissions( path: &str, ) -> HashSet { for (sub_path, child_node) in node.children { - let sub_path = format!("{}/{}", path, &sub_path); + let sub_path = format!("{}/{}", path, sub_path); paths = populate_acl_paths(paths, child_node, &sub_path); paths.insert(sub_path); } diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs index 3367fb2c1..e286784e8 100644 --- a/src/api2/admin/datastore.rs +++ b/src/api2/admin/datastore.rs @@ -1453,7 +1453,7 @@ pub fn download_file( tokio_util::codec::FramedRead::new(file, tokio_util::codec::BytesCodec::new()) .map_ok(|bytes| bytes.freeze()) .map_err(move |err| { - eprintln!("error during streaming of '{:?}' - {}", &path, err); + eprintln!("error during streaming of '{:?}' - {}", path, err); err }); let body = Body::wrap_stream(payload); @@ -2803,7 +2803,7 @@ async fn do_unmount(store: String, auth_id: Authid, to_stdout: bool) -> Result Result { } fn run_service_command(service: &str, cmd: &str, auth_id: Authid) -> Result { - let workerid = format!("srv{}", &cmd); + let workerid = format!("srv{}", cmd); let cmd = match cmd { "start" | "stop" | "restart" => cmd.to_string(), diff --git a/src/server/verify_job.rs b/src/server/verify_job.rs index ecc04d4af..adb84358f 100644 --- a/src/server/verify_job.rs +++ b/src/server/verify_job.rs @@ -22,7 +22,7 @@ pub fn do_verification_job( let ignore_verified_snapshots = verification_job.ignore_verified.unwrap_or(true); // FIXME encode namespace here for filter/ACL check? - let job_id = format!("{}:{}", &verification_job.store, job.jobname()); + let job_id = format!("{}:{}", verification_job.store, job.jobname()); let worker_type = job.jobtype().to_string(); let upid_str = WorkerTask::new_thread( &worker_type, -- 2.47.3