From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 9B0B51FF0AA for ; Tue, 03 Nov 2026 12:31:35 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E41942188F; Tue, 03 Nov 2026 12:31:34 +0100 (CET) From: Robert Obkircher To: pbs-devel@lists.proxmox.com Subject: [PATCH v1 proxmox-backup 0/8] fix warnings and rust edition incompatibilities Date: Tue, 3 Nov 2026 12:28:36 +0100 Message-ID: <20261103113054.184327-1-r.obkircher@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793705488661 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.515 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IDUTWTW6K4AYHF7YCQDSZVQK4IMCG5FJ X-Message-ID-Hash: IDUTWTW6K4AYHF7YCQDSZVQK4IMCG5FJ X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Apply some clippy suggestions, prepare for a future edition upgrade, and remove unused dependencies. To upgrade to the 2024 edition, we would still have to wrap some std::env functions in unsafe, and review countless drop order warnings reported by `cargo fix --edition`. Robert Obkircher (8): tree-wide: fix clippy::useless_borrows_in_formatting tape: fix clippy::question_mark api: fix clippy::unnecessary_lazy_evaluations cargo: update minimum rust version to 1.91 tree-wide: mark extern blocks as unsafe and add some safety comments tree-wide: remove redundant ref keyword in pattern matches tree-wide: add empty use<> bounds to return position impl traits cargo: remove unused dependencies Cargo.toml | 8 +------- debian/control | 1 - pbs-client/src/catalog_shell.rs | 2 +- pbs-client/src/http_client.rs | 2 +- pbs-client/src/pxar/extract.rs | 2 +- pbs-tape/src/blocked_writer.rs | 6 ++---- pbs-tape/src/sgutils2.rs | 19 ++++++++++++++++--- pbs-tools/src/cert.rs | 6 +++++- proxmox-file-restore/src/block_driver.rs | 2 +- src/api2/access/mod.rs | 2 +- src/api2/admin/datastore.rs | 4 ++-- src/api2/config/datastore.rs | 2 +- src/api2/config/sync.rs | 2 +- src/api2/node/disks/directory.rs | 2 +- src/api2/node/disks/zfs.rs | 2 +- src/api2/node/services.rs | 2 +- src/api2/node/tasks.rs | 7 +++---- src/server/verify_job.rs | 2 +- src/tape/inventory.rs | 10 ++++------ src/tape/media_pool.rs | 2 +- src/tape/media_set.rs | 2 +- 21 files changed, 46 insertions(+), 41 deletions(-) -- 2.47.3