[PATCH proxmox-perl-rs v7 28/41] notify: move proxmox-notify bindings from common to pve-rs

[Lukas Wagner <l.wagner@proxmox.com>]

PMG neither uses the notification stack, nor is it planned in the near
future. Shipping the bindings in 'common' is awkward, since it then
requires us to use the same feature flags in proxmox-notify for both,
PVE and PMG.

This reduces the number of dependencies for pmg-rs from 297 to 269, all
of the removed ones were unused before.

The module prefix changes from Proxmox::RS::Notify to PVE::RS::Notify,
which is a breaking change that requires changes in the callers.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>
---
 common/pkg/Makefile                       | 1 -
 common/src/bindings/mod.rs                | 3 ---
 pmg-rs/Cargo.toml                         | 1 -
 pve-rs/Makefile                           | 1 +
 pve-rs/src/bindings/mod.rs                | 3 +++
 {common => pve-rs}/src/bindings/notify.rs | 8 ++++----
 6 files changed, 8 insertions(+), 9 deletions(-)
 rename {common => pve-rs}/src/bindings/notify.rs (99%)

diff --git a/common/pkg/Makefile b/common/pkg/Makefile
index 1e63bfa..8c7ff98 100644
--- a/common/pkg/Makefile
+++ b/common/pkg/Makefile
@@ -23,7 +23,6 @@ PERLMOD_GENPACKAGE := /usr/lib/perlmod/genpackage.pl \
 PERLMOD_PACKAGES := \
 	  Proxmox::RS::APT::Repositories \
 	  Proxmox::RS::CalendarEvent \
-	  Proxmox::RS::Notify \
 	  Proxmox::RS::OIDC \
 	  Proxmox::RS::SharedCache \
 	  Proxmox::RS::Subscription
diff --git a/common/src/bindings/mod.rs b/common/src/bindings/mod.rs
index e0d1a3b..f122b9a 100644
--- a/common/src/bindings/mod.rs
+++ b/common/src/bindings/mod.rs
@@ -8,9 +8,6 @@ pub use apt_repositories::proxmox_rs_apt_repositories;
 mod calendar_event;
 pub use calendar_event::proxmox_rs_calendar_event;
 
-mod notify;
-pub use notify::proxmox_rs_notify;
-
 mod oidc;
 pub use oidc::proxmox_rs_oidc;
 
diff --git a/pmg-rs/Cargo.toml b/pmg-rs/Cargo.toml
index 23be254..f88a204 100644
--- a/pmg-rs/Cargo.toml
+++ b/pmg-rs/Cargo.toml
@@ -35,7 +35,6 @@ proxmox-config-digest = "1"
 proxmox-http = { version = "1", features = ["client-sync", "client-trait"] }
 proxmox-http-error = "1"
 proxmox-log = "1"
-proxmox-notify = "1"
 proxmox-openid =  "1"
 proxmox-shared-cache = "1"
 proxmox-subscription = "1.0.2"
diff --git a/pve-rs/Makefile b/pve-rs/Makefile
index f9ba49c..60f68c7 100644
--- a/pve-rs/Makefile
+++ b/pve-rs/Makefile
@@ -27,6 +27,7 @@ PERLMOD_GENPACKAGE := /usr/lib/perlmod/genpackage.pl \
 
 PERLMOD_PACKAGES := \
 	  PVE::RS::Firewall::SDN \
+	  PVE::RS::Notify \
 	  PVE::RS::NVML \
 	  PVE::RS::OCI \
 	  PVE::RS::OpenId \
diff --git a/pve-rs/src/bindings/mod.rs b/pve-rs/src/bindings/mod.rs
index f922982..143a62b 100644
--- a/pve-rs/src/bindings/mod.rs
+++ b/pve-rs/src/bindings/mod.rs
@@ -19,6 +19,9 @@ pub mod firewall;
 mod sdn;
 pub use sdn::fabrics::pve_rs_sdn_fabrics;
 
+mod notify;
+pub use notify::pve_rs_notify;
+
 #[allow(unused_imports)]
 pub use crate::common::bindings::*;
 
diff --git a/common/src/bindings/notify.rs b/pve-rs/src/bindings/notify.rs
similarity index 99%
rename from common/src/bindings/notify.rs
rename to pve-rs/src/bindings/notify.rs
index 409270a..ba713e3 100644
--- a/common/src/bindings/notify.rs
+++ b/pve-rs/src/bindings/notify.rs
@@ -1,6 +1,6 @@
-#[perlmod::package(name = "Proxmox::RS::Notify")]
-pub mod proxmox_rs_notify {
-    //! The `Proxmox::RS::Notify` package.
+#[perlmod::package(name = "PVE::RS::Notify")]
+pub mod pve_rs_notify {
+    //! The `PVE::RS::Notify` package.
     //!
     //! This implements the new notification API and support code.
     //!
@@ -45,7 +45,7 @@ pub mod proxmox_rs_notify {
         config: Mutex<Config>,
     }
 
-    perlmod::declare_magic!(Box<NotificationConfig> : &NotificationConfig as "Proxmox::RS::Notify");
+    perlmod::declare_magic!(Box<NotificationConfig> : &NotificationConfig as "PVE::RS::Notify");
 
     /// Method: Support `dclone` so this can be put into the `ccache` of `PVE::Cluster`.
     #[export(name = "STORABLE_freeze", raw_return)]
-- 
2.47.3