From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0269C1FF0AA for ; Tue, 03 Nov 2026 10:28:02 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 499DF2187B; Tue, 03 Nov 2026 10:27:41 +0100 (CET) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH manager v2 0/3] ui: lxc/qemu: reduce ambiguity when attaching unused disk Date: Tue, 3 Nov 2026 10:27:27 +0100 Message-ID: <20261103092730.21635-1-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793698054745 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.443 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 52Q5EKEE62J2AR4V7EH3PLTW2MHGON3M X-Message-ID-Hash: 52Q5EKEE62J2AR4V7EH3PLTW2MHGON3M X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Small UI quality of life improvements to reduce the ambiguity of attaching/adding an unused disk to vm/container: * rename 'Edit' button to 'Attach' for unused disks. * Convert existing buttons that display altText to `Proxmox.button.AltText` * Make button ordering of lxc/qemu hardware options consistent This also came it in a forum post [0] some time ago. [0] https://forum.proxmox.com/threads/how-do-i-reattach-a-disk-to-vm.108339/ Changes v1->v2: --------------- * utilize Proxmox.button.AltText for all buttons displaying alt text * re-order buttons in hardware/resources tab Previous Versions ----------------- v1: https://lore.proxmox.com/pve-devel/20261030124235.124337-1-e.huhsovitz@proxmox.com/ Elias Huhsovitz (3): ui: lxc/qemu: rename button label 'Edit' to 'Attach' for unused disks ui: lxc/qemu: convert buttons displaying altText to proxmoxAltTextButton ui: qemu: re-order buttons in hardware tab to match lxc layout www/manager6/lxc/Resources.js | 24 ++++++------------------ www/manager6/qemu/HardwareView.js | 27 +++++++++------------------ 2 files changed, 15 insertions(+), 36 deletions(-) -- 2.47.3