From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id A28EC1FF09D for ; Mon, 02 Nov 2026 00:00:03 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 933A62175D; Sun, 01 Nov 2026 23:59:15 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH manager 08/19] vzdump: show the error if a job could not get the global lock Date: Sun, 1 Nov 2026 23:58:35 +0100 Message-ID: <20261101225849.884587-9-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261101225849.884587-1-t.lamprecht@proxmox.com> References: <20261101225849.884587-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793573948305 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.400 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: G6FCCGKWGS47G5GCEQVMKUWS7WSDO5BR X-Message-ID-Hash: G6FCCGKWGS47G5GCEQVMKUWS7WSDO5BR X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: When a job could not get the global lock, the notification subject only said "multiple problems", as the error message ended with a newline. The worker then exited directly, so the task showed "unexpected status" instead of the reason. Remove the newline and die with the error, so the notification subject and the task status both name the actual problem. Signed-off-by: Thomas Lamprecht --- PVE/API2/VZDump.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/API2/VZDump.pm b/PVE/API2/VZDump.pm index 3856ec6bf..c8b66169e 100644 --- a/PVE/API2/VZDump.pm +++ b/PVE/API2/VZDump.pm @@ -140,8 +140,9 @@ __PACKAGE__->register_method({ $vzdump->getlock($upid); # only one process allowed }; if (my $err = $@) { + chomp($err); # otherwise reported as multiple problems $vzdump->send_notification([], 0, $err); - exit(-1); + die "$err\n"; } if (defined($param->{ionice})) { -- 2.47.3