From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 17E921FF09D for ; Sun, 01 Nov 2026 22:39:39 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A861B21721; Sun, 01 Nov 2026 22:38:53 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH network 07/10] sdn: ipam, dns: mark API tokens as sensitive Date: Sun, 1 Nov 2026 22:34:56 +0100 Message-ID: <20261101213835.353604-8-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261101213835.353604-1-t.lamprecht@proxmox.com> References: <20261101213835.353604-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793569121215 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.423 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: N3XJMZOB3KMVEL5Q4BNIQBKBIRP37OL2 X-Message-ID-Hash: N3XJMZOB3KMVEL5Q4BNIQBKBIRP37OL2 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The phpIPAM and Netbox tokens and the PowerDNS API key are stored in plain text in the cluster-wide IPAM and DNS configs. Marking them lets generic code like the system report redact them. Signed-off-by: Thomas Lamprecht --- NOTE: needs a libpve-common-perl that knows the 'sensitive' schema flag, otherwise 'pvesh verifyapi' rejects the IPAM and DNS API schemas. src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm | 1 + src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm | 1 + 2 files changed, 2 insertions(+) diff --git a/src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm b/src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm index dfb7932..3d88ea4 100644 --- a/src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm +++ b/src/PVE/Network/SDN/Dns/PowerdnsPlugin.pm @@ -24,6 +24,7 @@ sub properties { }, key => { type => 'string', + sensitive => 1, }, reversemaskv6 => { type => 'integer', diff --git a/src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm b/src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm index 395d72c..99378a4 100644 --- a/src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm +++ b/src/PVE/Network/SDN/Ipams/PhpIpamPlugin.pm @@ -19,6 +19,7 @@ sub properties { }, token => { type => 'string', + sensitive => 1, }, section => { type => 'integer', -- 2.47.3