From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BC3621FF09D for ; Sun, 01 Nov 2026 22:39:11 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 66C20216A2; Sun, 01 Nov 2026 22:38:52 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server 05/10] cloud-init: mark the password as sensitive Date: Sun, 1 Nov 2026 22:34:54 +0100 Message-ID: <20261101213835.353604-6-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261101213835.353604-1-t.lamprecht@proxmox.com> References: <20261101213835.353604-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793569121086 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.416 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: W5HJXZ5JU32T66KXVIKNUDDZWSYJ6DMC X-Message-ID-Hash: W5HJXZ5JU32T66KXVIKNUDDZWSYJ6DMC X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: For Windows guests the password is stored in plain text, as cloudbase-init needs it that way, and for other guests it is a crypt hash, which still allows offline guessing. Marking it lets generic code like the system report redact it without knowing the property name. Signed-off-by: Thomas Lamprecht --- NOTE: 'qm verifyapi' runs in the docs build and fails with a libpve-common-perl that does not know the 'sensitive' schema flag yet, so the build dependency needs a bump once that is released. src/PVE/QemuServer.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index b4a1a38d..2a3e266b 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -800,6 +800,7 @@ my $confdesc_cloudinit = { cipassword => { optional => 1, type => 'string', + sensitive => 1, description => 'cloud-init: Password to assign the user. Using this is generally not' . ' recommended. Use ssh keys instead. Also note that older cloud-init versions do not' . ' support hashed passwords.', -- 2.47.3