[PATCH common 01/10] section config: do not add isolated property lists on lookups

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

With isolated properties in use, looking up a property of a type that
has no isolated property list, like a plugin that is not isolated or an
unknown type, created an empty list for that type as a side effect.
Only init() reads these lists, and it starts from scratch, so nothing
depended on the extra entries. Still, a lookup should not modify the
plugin data, especially when the type comes from a config file.

No semantic change intended.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
---
 src/PVE/SectionConfig.pm                       | 3 ++-
 test/section_config_property_isolation_test.pl | 9 +++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/PVE/SectionConfig.pm b/src/PVE/SectionConfig.pm
index 66375ac..1febf76 100644
--- a/src/PVE/SectionConfig.pm
+++ b/src/PVE/SectionConfig.pm
@@ -1306,7 +1306,8 @@ sub get_property_schema {
 
     my $schema;
     if ($class->has_isolated_properties()) {
-        $schema = $pdata->{isolatedPropertyList}->{$type}->{$key};
+        my $isolated = $pdata->{isolatedPropertyList}->{$type};
+        $schema = $isolated->{$key} if $isolated;
     }
     $schema //= $pdata->{propertyList}->{$key};
 
diff --git a/test/section_config_property_isolation_test.pl b/test/section_config_property_isolation_test.pl
index 4c999c1..11b3142 100755
--- a/test/section_config_property_isolation_test.pl
+++ b/test/section_config_property_isolation_test.pl
@@ -472,6 +472,15 @@ my $update_schema = Conf->updateSchema();
 my $expected_update_schema = make_schema(1);
 is_deeply($update_schema, $expected_update_schema, "property-isolation update schema test");
 
+ok(
+    !defined(Conf->get_property_schema('unknown', 'another')),
+    "unknown type has no isolated properties",
+);
+ok(
+    !exists(Conf->private()->{isolatedPropertyList}->{unknown}),
+    "property lookup does not add a property list",
+);
+
 done_testing();
 
 1;
-- 
2.47.3