all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH qemu-server v2 6/7] drive: get tpm state size: add timeout parameter
Date: Thu, 29 Oct 2026 13:06:57 +0100	[thread overview]
Message-ID: <20261029120811.107814-7-f.ebner@proxmox.com> (raw)
In-Reply-To: <20261029120811.107814-1-f.ebner@proxmox.com>

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

New in v2.

 src/PVE/QemuServer/Drive.pm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/PVE/QemuServer/Drive.pm b/src/PVE/QemuServer/Drive.pm
index 7b288e78..951b7bb6 100644
--- a/src/PVE/QemuServer/Drive.pm
+++ b/src/PVE/QemuServer/Drive.pm
@@ -1323,9 +1323,12 @@ sub update_tpmstate_size {
 
 # Takes in a volume id and the storage configuration. Will then try to find
 # the actual storage size of the TPM drive. The final value has a minimum
-# determined by the TPMSTATE_DISK_SIZE static, which is 4MiB.
+# determined by the TPMSTATE_DISK_SIZE static, which is 4MiB. The default
+# timeout is 10 seconds and can be changed via the $timeout parameter.
 sub get_tpmstate_size {
-    my ($volid, $storecfg) = @_;
+    my ($volid, $storecfg, $timeout) = @_;
+
+    $timeout = 10 if !defined($timeout);
 
     die "a volume id has to be supplied to determine tpm state size"
         if !defined($volid);
@@ -1333,7 +1336,7 @@ sub get_tpmstate_size {
     die "the storage config has to be supplied to determine tpm state size"
         if !defined($storecfg);
 
-    my $size = eval { PVE::Storage::volume_size_info($storecfg, $volid, 10) };
+    my $size = eval { PVE::Storage::volume_size_info($storecfg, $volid, $timeout) };
     my $err = $@;
     $err = "no size in result" if !$err && !$size;
     warn "failed to get size of the tpm drive $volid: $err" if $err;
-- 
2.47.3





  parent reply	other threads:[~2026-10-29 12:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 12:06 [PATCH-SERIES qemu-server v2 0/7] fix #8209: clone disk: do not ignore failure to query size of target Fiona Ebner
2026-10-29 12:06 ` [PATCH qemu-server v2 1/7] block job: monitor: document that job-complete is not used if source differs from target Fiona Ebner
2026-10-30 10:37   ` Elias Huhsovitz
2026-10-29 12:06 ` [PATCH qemu-server v2 2/7] drive: get tpm state size: also warn if there was no size returned Fiona Ebner
2026-10-30 10:39   ` Elias Huhsovitz
2026-10-29 12:06 ` [PATCH qemu-server v2 3/7] api: clone disk: downgrade failure to register unused volume to warning Fiona Ebner
2026-10-30 10:56   ` Elias Huhsovitz
2026-10-29 12:06 ` [PATCH qemu-server v2 4/7] fix #8209: clone disk: do not ignore failure to query size of target Fiona Ebner
2026-10-30 10:36   ` Elias Huhsovitz
2026-10-29 12:06 ` [PATCH qemu-server v2 5/7] clone disk: abort early when failing to query size of source disk Fiona Ebner
2026-10-29 12:06 ` Fiona Ebner [this message]
2026-10-30 11:02   ` [PATCH qemu-server v2 6/7] drive: get tpm state size: add timeout parameter Elias Huhsovitz
2026-10-29 12:06 ` [PATCH qemu-server v2 7/7] clone disk: bump timeout for querying volume sizes to 1 minute Fiona Ebner
2026-10-30 11:14   ` Elias Huhsovitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261029120811.107814-7-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal